You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/27 13:26:35 UTC
[GitHub] [shardingsphere] JooKS-me opened a new pull request #10508: Add more RQL parser tests in DistSQLStatementParserEngineTest
JooKS-me opened a new pull request #10508:
URL: https://github.com/apache/shardingsphere/pull/10508
Refer #10505.
Changes proposed in this pull request:
- Add `assertParseShowShardingTableRules()`
- Add `assertParseShowShardingTableRule()`
- Add `assertParseShowShardingTableRuleFrom()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10508: Add more RQL parser tests in DistSQLStatementParserEngineTest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10508:
URL: https://github.com/apache/shardingsphere/pull/10508#issuecomment-849676009
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10508](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39e56fe) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e18d3cf6e02f2a26fb8e2c76094863fbd37e0cc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e18d3cf) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10508 +/- ##
============================================
- Coverage 68.82% 68.81% -0.01%
+ Complexity 712 711 -1
============================================
Files 1766 1765 -1
Lines 30297 30272 -25
Branches 5422 5420 -2
============================================
- Hits 20853 20833 -20
+ Misses 7838 7835 -3
+ Partials 1606 1604 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tsql/rql/impl/EncryptRulesQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRW5jcnlwdFJ1bGVzUXVlcnlCYWNrZW5kSGFuZGxlci5qYXZh) | `81.81% <0.00%> (-8.51%)` | :arrow_down: |
| [.../rql/impl/EncryptTableRuleQueryBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL2ltcGwvRW5jcnlwdFRhYmxlUnVsZVF1ZXJ5QmFja2VuZEhhbmRsZXIuamF2YQ==) | | |
| [...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=) | `89.67% <0.00%> (+1.93%)` | :arrow_up: |
| [...end/text/distsql/rql/RQLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10508/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL1JRTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `20.00% <0.00%> (+2.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e18d3cf...39e56fe](https://codecov.io/gh/apache/shardingsphere/pull/10508?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on pull request #10508: Add more RQL parser tests in DistSQLStatementParserEngineTest
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on pull request #10508:
URL: https://github.com/apache/shardingsphere/pull/10508#issuecomment-850077577
good job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #10508: Add more RQL parser tests in DistSQLStatementParserEngineTest
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #10508:
URL: https://github.com/apache/shardingsphere/pull/10508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org