You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/12/13 03:11:21 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #7437: [HUDI-5366] Closing metadata writer from within writeClient

danny0405 commented on code in PR #7437:
URL: https://github.com/apache/hudi/pull/7437#discussion_r1046617209


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -752,6 +752,7 @@ public void dropMetadataPartitions(List<MetadataPartitionType> metadataPartition
       LOG.warn("Deleting pending indexing instant from the timeline for partition: " + partitionPath);
       deletePendingIndexingInstant(dataMetaClient, partitionPath);
     }
+    closeInternal();
   }
 

Review Comment:
   Can we let the `HoodieBackedTableMetadataWriter` implement `AutoClosable` so that it can be used in the try finally block. Can we also fix `HoodieFlinkWriteClient#writeTableMetadata`,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org