You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/12 08:28:43 UTC
[GitHub] [skywalking] buxingzhe opened a new issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
buxingzhe opened a new issue #6185:
URL: https://github.com/apache/skywalking/issues/6185
### Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
When segment span reference list is not empty, for MultiScopesAnalysisListener.parseEntry method, the SourceBuilder sets endpoint name before service name is set which makes the endpoint name grouping doesn't work due to miss service name.
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
- What do you want to know?
___
### Bug
- Which version of SkyWalking, OS, and JRE?
SkyWalking 8.3.0, Linux, JDK 11
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
Just set the service name before setting endpoint in source builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758506771
OK, I'll commit a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe removed a comment on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe removed a comment on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758496162
<img width="960" alt="endpoint-name-group-failed" src="https://user-images.githubusercontent.com/5172430/104289210-d4dd6f80-54f3-11eb-9efa-8da635502682.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe removed a comment on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe removed a comment on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758495241
![Uploading endpoint-name-group-failed.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758496162
<img width="960" alt="endpoint-name-group-failed" src="https://user-images.githubusercontent.com/5172430/104289210-d4dd6f80-54f3-11eb-9efa-8da635502682.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758498493
<img width="960" alt="endpoint-name-group-failed" src="https://user-images.githubusercontent.com/5172430/104289768-8086bf80-54f4-11eb-9b69-09f89b57c3fd.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758495241
![Uploading endpoint-name-group-failed.png…]()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758499974
Just refer to my screenshot, as the service name is null, we can't get the right group rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758505469
OK, I can get your point now. Yes, the naming mechanism fails because of the order of setting.
This is very tricky and hard to find.
My suggestion is adding a `prepare` method for `SourceBuilder` class, which should be called before `toXXX` in the `MultiScopesAnalysisListener#build`. And follow your path, I can see `slowDatabaseAccesses` and `logicEndpointBuilders` have bugs for the whole `NamingControl`. Could you fix this in the same way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] buxingzhe commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
buxingzhe commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758499500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6185:
URL: https://github.com/apache/skywalking/issues/6185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6185: Endpoint name group doesn't work due to service name not set in SourceBuilder
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6185:
URL: https://github.com/apache/skywalking/issues/6185#issuecomment-758498450
Take a look at `SourceBuilder#setSourceEndpointName`? I can see the `NamingControl` mechanism working in there. Anything I missed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org