[GitHub] [avro] martin-g commented on a change in pull request #1497: AVRO-3347 Update addNamespace to AddNamespace

[GitBox <gi...@apache.org>]

martin-g commented on a change in pull request #1497:
URL: https://github.com/apache/avro/pull/1497#discussion_r797008933



##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGen.cs
##########
@@ -148,6 +145,20 @@ protected virtual CodeNamespace addNamespace(string name)
             return ns;
         }
 
+        /// <summary>
+        /// Adds a namespace object for the given name into the dictionary if it doesn't exist yet.
+        /// </summary>
+        /// <param name="name">name of namespace.</param>
+        /// <returns>
+        /// Code Namespace.
+        /// </returns>
+        /// <exception cref="System.ArgumentNullException">name - name cannot be null.</exception>
+        [Obsolete("Use AddNamespace. This call will be deprecated in a future release.")]

Review comment:
       Please see https://github.com/apache/avro/pull/1484#discussion_r796496760
   I am not native English speaker, so I might be wrong !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org