You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/27 08:17:13 UTC
[GitHub] shuai-xu commented on a change in pull request #6734:
[FLINK-9455][RM] Add support for multi task slot TaskExecutors
shuai-xu commented on a change in pull request #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors
URL: https://github.com/apache/flink/pull/6734#discussion_r220831661
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
##########
@@ -530,14 +541,50 @@ private void registerSlot(
removeSlot(slotId);
}
- TaskManagerSlot slot = new TaskManagerSlot(
+ final TaskManagerSlot slot = createAndRegisterTaskManagerSlot(slotId, resourceProfile, taskManagerConnection);
+
+ final PendingTaskManagerSlot pendingTaskManagerSlot;
+
+ if (allocationId == null) {
+ pendingTaskManagerSlot = findExactlyMatchingPendingTaskManagerSlot(resourceProfile);
Review comment:
Why use exactly matching here but isMatching in other place? I think we should make the methods for finding pending task manager slots extendable so user can define their own matching algorithm according to need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services