You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 18:02:00 UTC

[GitHub] [airflow] kazanzhy commented on pull request #21307: Fixed PostgresToGCSOperator fail on empty resultset for use_server_side_cursor=True

kazanzhy commented on pull request #21307:
URL: https://github.com/apache/airflow/pull/21307#issuecomment-1030223628


   Today I made few tests:
   
   Current version (code from `main` branch):
   - Query returns rows and use_server_side_cursor=False: file with data
   - Query returns rows and use_server_side_cursor=True: file with data
   - Query returns nothing and use_server_side_cursor=False: empty file
   - Query return nothing and use_server_side_cursor=True: ERROR
   
   Updated version (this PR code):
   - Query returns rows and use_server_side_cursor=False: file with data
   - Query returns rows and use_server_side_cursor=True: file with data
   - Query returns nothing and use_server_side_cursor=False: empty file
   - Query return nothing and use_server_side_cursor=True: empty file
   
   The last one is not what is expected in the issue but I think creating the empty file is the right behavior
   > I'm expected, that operator on empty table not creating file and no upload it on Google Cloud.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org