You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Matthias Pohl (Jira)" <ji...@apache.org> on 2022/03/02 13:19:00 UTC
[jira] [Updated] (FLINK-26450) FileStateHandle.discardState does not process return value
[ https://issues.apache.org/jira/browse/FLINK-26450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Pohl updated FLINK-26450:
----------------------------------
Description: The retryable cleanup does not work properly if there's an error appearing during the {{FileSystem.delete}} call which is used within [FileStateHandle.discardState|https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileStateHandle.java#L85]. Some {{FileSystem}} implementations (e.g. S3 presto; see [PrestoS3FileSystem:512|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L512] through [PrestoS3FileSystem.delete(Path, boolean)|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L480]) return {{false}} in case of an error which will be swallowed in {{FileStateHandle.discardState}}. (was: The retryable cleanup does not work properly if there's an error appearing during the {{FileSystem.delete}} call which is used within {{FileStateHandle.discardState}}. Some {{FileSystem}} implementations (e.g. S3 presto) return {{false}} in case of an error which will be swalled in {{FileStateHandle.discardState}}.)
> FileStateHandle.discardState does not process return value
> ----------------------------------------------------------
>
> Key: FLINK-26450
> URL: https://issues.apache.org/jira/browse/FLINK-26450
> Project: Flink
> Issue Type: Bug
> Components: Connectors / FileSystem, Runtime / Coordination
> Affects Versions: 1.15.0, 1.13.6, 1.14.3
> Reporter: Matthias Pohl
> Priority: Major
>
> The retryable cleanup does not work properly if there's an error appearing during the {{FileSystem.delete}} call which is used within [FileStateHandle.discardState|https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FileStateHandle.java#L85]. Some {{FileSystem}} implementations (e.g. S3 presto; see [PrestoS3FileSystem:512|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L512] through [PrestoS3FileSystem.delete(Path, boolean)|https://github.com/prestodb/presto/blob/master/presto-hive/src/main/java/com/facebook/presto/hive/s3/PrestoS3FileSystem.java#L480]) return {{false}} in case of an error which will be swallowed in {{FileStateHandle.discardState}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)