You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Andrea Pescetti <pe...@openoffice.org> on 2011/11/21 00:27:12 UTC

[CODE] configure.in: yes/no messages swapped in --enable-copyleft

It seems that the "yes" and "no" messages corresponding to the 
"--enable-copyleft" option are swapped in configure.in; this has no 
impact on the build, but it gives the user a wrong feedback about the 
options he specified.

The fix would just consist in swapping the "yes" and "no" messages; for 
those who prefer to see it in the form of a (trivial) patch, here it is.
   ---
Index: configure.in
===================================================================
--- configure.in	(revision 1204230)
+++ configure.in	(local copy)
@@ -1233,37 +1233,37 @@
  AC_MSG_CHECKING([whether to enable copyleft components])
  if test "$enable_copyleft" != "yes"; then

     enable_mozilla="no"
     enable_nss_module="no"
     enable_gstreamer="no"
     with_myspell_dicts="no"

     DISABLE_HUNSPELL="TRUE"
     DISABLE_HYPHEN="TRUE"
     DISABLE_SAXON="TRUE"

     BUILD_EPM="NO"

-   AC_MSG_RESULT([yes])
+   AC_MSG_RESULT([no])

  else

     DISABLE_HUNSPELL=
     DISABLE_HYPHEN=
     DISABLE_SAXON=

-   AC_MSG_RESULT([no])
+   AC_MSG_RESULT([yes])

  fi
  AC_SUBST(DISABLE_HUNSPELL)
  AC_SUBST(DISABLE_HYPHEN)
  AC_SUBST(DISABLE_SAXON)
  AC_SUBST(BUILD_EPM)


  AC_MSG_CHECKING([whether to enable native CUPS support])
  if test "$test_cups" = "yes" -a \( "$enable_cups" = "yes" -o 
"$enable_cups" = "TRUE" \) ; then
     ENABLE_CUPS="TRUE"
     AC_MSG_RESULT([yes])
  else
     ENABLE_CUPS=""
   ---
Regards,
   Andrea.

Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft

Posted by Andrea Pescetti <pe...@openoffice.org>.
On 22/11/2011 Andre Fischer wrote:
> On 21.11.2011 19:59, Andrea Pescetti wrote:
>> Thanks for the information, but since "configure" is writing a wrong
>> (and potentially confusing) message, and the fix I sent is trivial and
>> totally harmless, why not just fix it? ...
> You are absolutely right, and I would have applied the patch but I do
> not yet have commit rights.

Now both of us do have commit rights... I committed this trivial, 
risk-free fix to test my SVN access, everything OK. If that section of 
configure.in is going to be rewritten in the next few days, it's 
absolutely no problem for me.

Regards,
   Andrea.

Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft

Posted by Andre Fischer <af...@a-w-f.de>.
On 21.11.2011 19:59, Andrea Pescetti wrote:
> Andre Fischer wrote:
>> good point but please keep in mind that this is a temporary workaround.
>> Much work is currently being done ... the --enable-copyleft switch
>> will not live for very long.
>
> Thanks for the information, but since "configure" is writing a wrong
> (and potentially confusing) message, and the fix I sent is trivial and
> totally harmless, why not just fix it?
>
> It takes less to fix it than to discuss it by e-mail, and people
> experimenting with the --enable-copyleft switch will be reassured if
> configure gives them the proper feedback. And since I think that the new
> --enable-x-license (or whatever it is) section in configure.in will be
> copied and pasted from --enable-copyleft, it is probably good to get it
> right there even if it is going away soon.

You are absolutely right, and I would have applied the patch but I do 
not yet have commit rights.
I just did not want you to be disappointed when your fix is removed in 
(hopefully) a few days.

-Andre

Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft

Posted by Pedro Giffuni <pf...@apache.org>.
FWIW;

I have already touched that configure script more than
I want to already but I would favor reverting the
enable-copyleft switch: it is particularly wrong with
weak copyleft.

We should just remove the internal versions for anything
copyleft but let people use the preinstalled packages
that are detected (which is the general line of what
we are doing in the IP clearance anyways).

cheers,

Pedro.

--- On Mon, 11/21/11, Andrea Pescetti <pe...@openoffice.org> wrote:
...
> Andre Fischer wrote:
> > good point but please keep in mind that this is a
> temporary workaround.
> > Much work is currently being done ... the
> --enable-copyleft switch
> > will not live for very long.
> 
> Thanks for the information, but since "configure" is
> writing a wrong (and potentially confusing) message, and the
> fix I sent is trivial and totally harmless, why not just fix
> it?
> 
> It takes less to fix it than to discuss it by e-mail, and
> people experimenting with the --enable-copyleft switch will
> be reassured if configure gives them the proper feedback.
> And since I think that the new --enable-x-license (or
> whatever it is) section in configure.in will be copied and
> pasted from --enable-copyleft, it is probably good to get it
> right there even if it is going away soon.
> 
> Regards,
>   Andrea.
>

Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft

Posted by Andrea Pescetti <pe...@openoffice.org>.
Andre Fischer wrote:
> good point but please keep in mind that this is a temporary workaround.
> Much work is currently being done ... the --enable-copyleft switch
> will not live for very long.

Thanks for the information, but since "configure" is writing a wrong 
(and potentially confusing) message, and the fix I sent is trivial and 
totally harmless, why not just fix it?

It takes less to fix it than to discuss it by e-mail, and people 
experimenting with the --enable-copyleft switch will be reassured if 
configure gives them the proper feedback. And since I think that the new 
--enable-x-license (or whatever it is) section in configure.in will be 
copied and pasted from --enable-copyleft, it is probably good to get it 
right there even if it is going away soon.

Regards,
   Andrea.

Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft

Posted by Andre Fischer <af...@a-w-f.de>.
Hi Andrea,

good point but please keep in mind that this is a temporary workaround. 
  Much work is currently being done to remove the category x license 
code.  When that is done we need a different switch to make the category 
b license code (eg MPL) optional.  Therefore the --enable-copyleft 
switch will not live for very long.

Regards,
Andre

On 21.11.2011 00:27, Andrea Pescetti wrote:
> It seems that the "yes" and "no" messages corresponding to the
> "--enable-copyleft" option are swapped in configure.in; this has no
> impact on the build, but it gives the user a wrong feedback about the
> options he specified.
>
> The fix would just consist in swapping the "yes" and "no" messages; for
> those who prefer to see it in the form of a (trivial) patch, here it is.
> ---
> Index: configure.in
> ===================================================================
> --- configure.in (revision 1204230)
> +++ configure.in (local copy)
> @@ -1233,37 +1233,37 @@
> AC_MSG_CHECKING([whether to enable copyleft components])
> if test "$enable_copyleft" != "yes"; then
>
> enable_mozilla="no"
> enable_nss_module="no"
> enable_gstreamer="no"
> with_myspell_dicts="no"
>
> DISABLE_HUNSPELL="TRUE"
> DISABLE_HYPHEN="TRUE"
> DISABLE_SAXON="TRUE"
>
> BUILD_EPM="NO"
>
> - AC_MSG_RESULT([yes])
> + AC_MSG_RESULT([no])
>
> else
>
> DISABLE_HUNSPELL=
> DISABLE_HYPHEN=
> DISABLE_SAXON=
>
> - AC_MSG_RESULT([no])
> + AC_MSG_RESULT([yes])
>
> fi
> AC_SUBST(DISABLE_HUNSPELL)
> AC_SUBST(DISABLE_HYPHEN)
> AC_SUBST(DISABLE_SAXON)
> AC_SUBST(BUILD_EPM)
>
>
> AC_MSG_CHECKING([whether to enable native CUPS support])
> if test "$test_cups" = "yes" -a \( "$enable_cups" = "yes" -o
> "$enable_cups" = "TRUE" \) ; then
> ENABLE_CUPS="TRUE"
> AC_MSG_RESULT([yes])
> else
> ENABLE_CUPS=""
> ---
> Regards,
> Andrea.