You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/27 18:08:54 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7454: Revert "sched: add nx_wait, nx_waitid and nx_waitpid"
xiaoxiang781216 opened a new pull request, #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454
## Summary
This reverts commit de2a9d8a771ac4434d94a654e2b60c4fd0de19a1.
## Impact
Remove the unused nx_wait[id|pid]
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7454: Revert "sched: add nx_wait, nx_waitid and nx_waitpid"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454#discussion_r1007236474
##########
sched/sched/sched_waitpid.c:
##########
@@ -445,164 +586,24 @@ pid_t nx_waitpid(pid_t pid, int *stat_loc, int options)
}
}
- /* On success, return the PID */
-
- ret = pid;
+#ifdef CONFIG_SMP
+ leave_critical_section(flags);
+#else
+ sched_unlock();
+#endif
+ leave_cancellation_point();
+ return (int)pid;
Review Comment:
```suggestion
return pid;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7454: sched: remove the unused function nx_wait and nx_waitid
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7454: sched: remove the unused function nx_wait and nx_waitid
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454#issuecomment-1294364013
> Seems that kernel part still use it
>
> ```
> task/task_spawn.c: In function 'task_spawn':
> Error: task/task_spawn.c:425:9: error: implicit declaration of function 'nx_waitpid'; did you mean 'waitpid'? [-Werror=implicit-function-declaration]
> 425 | ret = nx_waitpid(proxy, &status, 0);
> | ^~~~~~~~~~
> | waitpid
> ```
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7454: Revert "sched: add nx_wait, nx_waitid and nx_waitpid"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454#issuecomment-1294078997
Seems that kernel part still use it
```
task/task_spawn.c: In function 'task_spawn':
Error: task/task_spawn.c:425:9: error: implicit declaration of function 'nx_waitpid'; did you mean 'waitpid'? [-Werror=implicit-function-declaration]
425 | ret = nx_waitpid(proxy, &status, 0);
| ^~~~~~~~~~
| waitpid
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7454: Revert "sched: add nx_wait, nx_waitid and nx_waitpid"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7454:
URL: https://github.com/apache/incubator-nuttx/pull/7454#discussion_r1007546573
##########
sched/sched/sched_waitpid.c:
##########
@@ -445,164 +586,24 @@ pid_t nx_waitpid(pid_t pid, int *stat_loc, int options)
}
}
- /* On success, return the PID */
-
- ret = pid;
+#ifdef CONFIG_SMP
+ leave_critical_section(flags);
+#else
+ sched_unlock();
+#endif
+ leave_cancellation_point();
+ return (int)pid;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org