You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2015/01/20 17:38:54 UTC
svn commit: r1653290 - /subversion/trunk/subversion/libsvn_fs_x/fs.h
Author: stefan2
Date: Tue Jan 20 16:38:54 2015
New Revision: 1653290
URL: http://svn.apache.org/r1653290
Log:
No FSX structure that is used as a cache key shall contain padding
(which would remain un-initialized by default - containing random data).
This is for efficiency only.
* subversion/libsvn_fs_x/fs.h
(svn_fs_x__representation_cache_key_t): Expand the element types such
that there is no padding on any
platform.
Modified:
subversion/trunk/subversion/libsvn_fs_x/fs.h
Modified: subversion/trunk/subversion/libsvn_fs_x/fs.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_x/fs.h?rev=1653290&r1=1653289&r2=1653290&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/fs.h (original)
+++ subversion/trunk/subversion/libsvn_fs_x/fs.h Tue Jan 20 16:38:54 2015
@@ -217,14 +217,16 @@ typedef struct svn_fs_x__pair_cache_key_
apr_int64_t second;
} svn_fs_x__pair_cache_key_t;
-/* Key type that identifies a representation / rep header. */
+/* Key type that identifies a representation / rep header.
+
+ Note: Cache keys should require no padding. */
typedef struct svn_fs_x__representation_cache_key_t
{
/* Revision that contains the representation */
- svn_revnum_t revision;
+ apr_int64_t revision;
- /* Packed or non-packed representation? */
- svn_boolean_t is_packed;
+ /* Packed or non-packed representation (boolean)? */
+ apr_int64_t is_packed;
/* Item index of the representation */
apr_uint64_t item_index;