You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/20 17:14:20 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic

saintstack commented on a change in pull request #1069: HBASE-23708 Support metrics for region traffic
URL: https://github.com/apache/hbase/pull/1069#discussion_r368655764
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java
 ##########
 @@ -44,31 +44,48 @@ public void close() {
     source.close();
   }
 
-  public void updatePut() {
+  public void updatePut(final long size) {
     source.updatePut();
+    source.updatePutBytes(size);
+    source.updateReceivedBytes(size);
 
 Review comment:
   What is the difference between put and received? They are not the same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services