[GitHub] [lucene-solr] iverase commented on a change in pull request #1538: LUCENE-9368: Use readLELongs to read docIds on BKD leaf nodes

[GitBox <gi...@apache.org>]

iverase commented on a change in pull request #1538:
URL: https://github.com/apache/lucene-solr/pull/1538#discussion_r431855701



##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java
##########
@@ -498,6 +500,7 @@ public IntersectState(IndexInput in, int numDims,
       this.scratchMinIndexPackedValue = new byte[packedIndexBytesLength];
       this.scratchMaxIndexPackedValue = new byte[packedIndexBytesLength];
       this.index = indexVisitor;
+      this.scratchLongs = new long[maxPointsInLeafNode / 2];

Review comment:
       Not really. We read as many longs as we can so if the count is un-even for 32bits integer, the last four bytes are read from the index. See Line 120 of DocIdsWriter.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org