You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/12/07 17:35:13 UTC
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #878: Add support for NuttX
apache-mynewt-bot removed a comment on pull request #878:
URL: https://github.com/apache/mynewt-nimble/pull/878#issuecomment-719946791
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/transport/socket/src/ble_hci_socket.c
<details>
```diff
@@ -54,7 +54,7 @@
#if MYNEWT_VAL(BLE_SOCK_USE_LINUX_BLUE)
#include <sys/errno.h>
#define BTPROTO_HCI 1
-#define HCI_CHANNEL_RAW 0
+#define HCI_CHANNEL_RAW 0
#define HCI_CHANNEL_USER 1
#define HCIDEVUP _IOW('H', 201, int)
#define HCIDEVDOWN _IOW('H', 202, int)
```
</details>
#### porting/nimble/include/log_common/log_common.h
<details>
```diff
@@ -43,12 +43,12 @@
#define LOG_LEVEL_MAX (15)
#define LOG_LEVEL_STR(level) \
- (LOG_LEVEL_DEBUG == level ? "DEBUG" :\
- (LOG_LEVEL_INFO == level ? "INFO" :\
- (LOG_LEVEL_WARN == level ? "WARN" :\
- (LOG_LEVEL_ERROR == level ? "ERROR" :\
- (LOG_LEVEL_CRITICAL == level ? "CRITICAL" :\
- "UNKNOWN")))))
+ (LOG_LEVEL_DEBUG == level ? "DEBUG" : \
+ (LOG_LEVEL_INFO == level ? "INFO" : \
+ (LOG_LEVEL_WARN == level ? "WARN" : \
+ (LOG_LEVEL_ERROR == level ? "ERROR" : \
+ (LOG_LEVEL_CRITICAL == level ? "CRITICAL" : \
+ "UNKNOWN")))))
/* XXX: These module IDs are defined for backwards compatibility. Application
* code should use the syscfg settings directly. These defines will be removed
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org