[GitHub] [trafficserver] maskit commented on a diff in pull request #9486: QUIC: Add support to configure UDP max payload limit.

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9486:
URL: https://github.com/apache/trafficserver/pull/9486#discussion_r1131213628


##########
iocore/net/QUICNetProcessor_quiche.cc:
##########
@@ -90,8 +90,8 @@ QUICNetProcessor::start(int, size_t stacksize)
   }
 
   quiche_config_set_max_idle_timeout(this->_quiche_config, params->no_activity_timeout_in());
-  quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, 16384);
-  quiche_config_set_max_send_udp_payload_size(this->_quiche_config, 16384);
+  quiche_config_set_max_recv_udp_payload_size(this->_quiche_config, params->get_max_recv_udp_payload_size_in());
+  quiche_config_set_max_send_udp_payload_size(this->_quiche_config, params->get_max_send_udp_payload_size_in());

Review Comment:
   And `_in` is correct for the both here. It's for inbound connections. The `_out` will be used when we support H*3* to  origin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org