You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/12 05:38:05 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

junichi11 opened a new pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446


   https://issues.apache.org/jira/browse/NETBEANS-4443
   
   - https://wiki.php.net/rfc/nullsafe_operator
   - Fix the parser and lexers
   - Add the `isNullsafe()` method to `Dispatch`
   - Add/Fix unit tests for the parser and the lexers
   - Fix the `PHP80UnhandledError`
   - Fix the `PHP5ErrorHandlerImpl` (also add "fn", "match", "??=" because they are missing)
   - Fix the formatting feature
   - Fix the code completion feature
   - Fix the IndentationCounter
   - Add unit tests for GotoDeclaration and MarkOccurrences
   
   #### PHP 8.0 (Project Properties)
   
   ![nb-php80-nullsafe-operator](https://user-images.githubusercontent.com/738383/95708819-33e2dc80-0c98-11eb-8128-a11236b37d1f.png)
   
   #### PHP 7.4 (Project Properties)
   
   ![nb-php80-nullsafe-operator-php74](https://user-images.githubusercontent.com/738383/95708828-3ba28100-0c98-11eb-9524-0e91db5f879e.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik merged pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446#issuecomment-707219594


   @junichi11  BTW, again, plenty of files, really not possible to review it :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446#issuecomment-707482124


   I just rebased. (No changes. Checks were passed once.)
   ![nb-pr2446](https://user-images.githubusercontent.com/738383/95816248-95b74b00-0d59-11eb-8fd9-ba04bae17543.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] junichi11 commented on pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446#issuecomment-707225956


   > There are some failures on JDK 14, could you please check them? Thanks.
   
   Will try restarting the job. (Maybe, no problem because it's the test of java.hints)
   
   > BTW, again, plenty of files, really not possible to review it :)
   
   Yes :)
   
   Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] tmysik commented on pull request #2446: [NETBEANS-4443] PHP 8.0 Support: Nullsafe operator

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2446:
URL: https://github.com/apache/netbeans/pull/2446#issuecomment-707218840


   @junichi11 There are some failures on JDK 14, could you please check them? Thanks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists