You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "Stefan Seifert (JIRA)" <ji...@apache.org> on 2012/07/20 23:09:34 UTC

[jira] [Updated] (FELIX-3550) Reimplement the SCR Generator

     [ https://issues.apache.org/jira/browse/FELIX-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seifert updated FELIX-3550:
----------------------------------

    Attachment: 120720_FELIX-3550_fixes.patch

i've tested the refactored implementation with some of our more complex projects and found - and fixed - several issues. patch attached [^120720_FELIX-3550_fixes.patch].

issues in detail:
- custom annotations provided with an AnnotationProvider where not detected if their retention policy was RUNTIME. this may be required if the annotation is not only used for the SCR plugin but for other usecases as well that require RUNTIME.
- annotated methods with array parameters caused errors during processing
- annotated overloaded methods with same signature parameter count where not detected properly
- NPE was thrown if a component hat no configuration policy property set
- replaced two System.out.println's with debug log outputs
                
> Reimplement the SCR Generator
> -----------------------------
>
>                 Key: FELIX-3550
>                 URL: https://issues.apache.org/jira/browse/FELIX-3550
>             Project: Felix
>          Issue Type: Task
>          Components: Maven SCR Plugin, SCR Annotations
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin-1.8.0, scr ant task 1.2.0, scr generator 1.2.0, scr annotations 1.7.0
>
>         Attachments: 120720_FELIX-3550_fixes.patch
>
>
> The current implementation of the maven scr plugin and generator has grown over time and is very complex. It makes a lot of assumptions about hidden datastructures. This is partially due to the use of QDox in the beginning of the plugin
> As we drop the support for javadoc annotations, we can also drop qdox and clean up the implementation
> This also makes developing new features easier

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira