You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/12/08 20:29:48 UTC
Review Request 41098: Fixed punctuation usage in some error messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41098/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Error messages should generally not end in punctuation.
Diffs
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
src/master/validation.cpp 6a0296b17ffbc3b0f7b8b8dca172e143684fde14
src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp b7ba00bc495001380f01737e46e8671ffe1c2ef7
Diff: https://reviews.apache.org/r/41098/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 41098: Fixed punctuation usage in some error
messages.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41098/#review109381
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2015, 7:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41098/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 7:29 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Error messages should generally not end in punctuation.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
> src/master/validation.cpp 6a0296b17ffbc3b0f7b8b8dca172e143684fde14
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp b7ba00bc495001380f01737e46e8671ffe1c2ef7
>
> Diff: https://reviews.apache.org/r/41098/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>