You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:00:19 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #22975: Resolve XComArg's before trying to unmap MappedOperators

ashb commented on code in PR #22975:
URL: https://github.com/apache/airflow/pull/22975#discussion_r849652248


##########
airflow/models/mappedoperator.py:
##########
@@ -670,10 +675,12 @@ def prepare_for_execution(self) -> "MappedOperator":
         # we don't need to create a copy of the MappedOperator here.
         return self
 
+    @provide_session
     def render_template_fields(
         self,
         context: Context,
         jinja_env: Optional["jinja2.Environment"] = None,
+        session: Session = NEW_SESSION,

Review Comment:
   Oh probably yeah. (It's a mess. I don't like that `@provide_session` expunges all. Add it to the list to fix)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org