[GitHub] [singa] nudles commented on a change in pull request #632: make astype return new tensor

[GitBox <gi...@apache.org>]

nudles commented on a change in pull request #632: make astype return new tensor
URL: https://github.com/apache/singa/pull/632#discussion_r395412130
 
 

 ##########
 File path: src/core/tensor/tensor.cc
 ##########
 @@ -152,29 +152,24 @@ Tensor Resize(const Tensor &in, const Shape &shape) {
     }                                                                          \
   } while (0)
 
-Tensor &Tensor::AsType(const DataType type) {
+// return new tensor
+Tensor Tensor::AsType(const DataType type) {
 
 Review comment:
   do we need to add a flag for in-place? default can be False.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services