You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/19 08:29:57 UTC
[GitHub] [spark] Ngone51 commented on a change in pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure
Ngone51 commented on a change in pull request #28866:
URL: https://github.com/apache/spark/pull/28866#discussion_r442660531
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -405,6 +405,15 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
runEvent(JobCancelled(jobId, None))
}
+ /** Make task set success and check result. */
+ private def checkAnswer(
+ taskSet: TaskSet,
+ results: Seq[(TaskEndReason, Any)],
+ expected: Map[Int, Any]): Unit = {
Review comment:
nit: 4 indents
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -405,6 +405,15 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
runEvent(JobCancelled(jobId, None))
}
+ /** Make task set success and check result. */
Review comment:
It doesn't make the whole taskset success but only some tasks in the taskset success?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -405,6 +405,15 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
runEvent(JobCancelled(jobId, None))
}
+ /** Make task set success and check result. */
+ private def checkAnswer(
+ taskSet: TaskSet,
+ results: Seq[(TaskEndReason, Any)],
Review comment:
I think the name of `results` is not appropriate here considering its usage and also confused with `this.results` below. Maybe, `taskEndInfos`?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -405,6 +405,15 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
runEvent(JobCancelled(jobId, None))
}
+ /** Make task set success and check result. */
+ private def checkAnswer(
Review comment:
Maybe, `completeAndCheckAnswer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org