[jira] [Commented] (MINIFICPP-665) Fix basestream references

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682707#comment-16682707 ] 

ASF GitHub Bot commented on MINIFICPP-665:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/435

    MINIFICPP-665: Add reference checks for self

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-665

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #435
    
----
commit 6bf85fd9f4f188cfa0fcbc95fe60f53644b24bca
Author: Marc Parisi <ph...@...>
Date:   2018-11-11T02:06:08Z

    MINIFICPP-665: Add reference checks for self

----


> Fix basestream references
> -------------------------
>
>                 Key: MINIFICPP-665
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-665
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Mr TheSegfault
>            Assignee: Mr TheSegfault
>            Priority: Major
>
> At some point basestream was changed to be a composable pointer ( hence the name base stream ) as a wrapper for a variety of streams. this caused a bug where a self reference could occur. We overload this stream to be a self reference since it extends DataStream. This is a very likely usage so we can avoid the bugs by simply checking if the composition is a reference to self. This reference to self won't be removed in the interest of time and re-using Serializable's interface. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)