You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jacob Hookom (JIRA)" <my...@incubator.apache.org> on 2005/08/24 17:28:13 UTC
[jira] Created: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
---------------------------------------------------------------------
Key: MYFACES-441
URL: http://issues.apache.org/jira/browse/MYFACES-441
Project: MyFaces
Type: Bug
Components: JSF 1.1
Versions: 1.0.9 beta
Environment: Tomcat, FireFox/Mozilla Browser
Reporter: Jacob Hookom
Assigned to: Martin Marinschek
Priority: Critical
Fix For: Nightly Build
The contract between ViewHandler and RenderKit for creating a ResponseWriter is that the ViewHandler should suggest a list of supported contentTypes. It is the RenderKit's job to pick the appropriate one based on it's output-- not just any of them.
In the case of Firefox, the first item it sends is 'text/xml, ....', the HtmlRenderKit in MyFaces just says, use the first item returned, so the response is set to be contentType of 'text/xml'.
This causes issues since the browser gets a response, renders it, but treats the content with comments <!-- --> as XML-- so that means the css isn't used, and commented JavaScript isn't seen.
This is a major blocker.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-441?page=comments#action_12319854 ]
Martin Marinschek commented on MYFACES-441:
-------------------------------------------
Yes.
What a mess.
Get me my xhtml compliant components ;)
regards,
Martin
> CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> ---------------------------------------------------------------------
>
> Key: MYFACES-441
> URL: http://issues.apache.org/jira/browse/MYFACES-441
> Project: MyFaces
> Type: Bug
> Components: JSF 1.1
> Versions: 1.0.9 beta
> Environment: Tomcat, FireFox/Mozilla Browser
> Reporter: Jacob Hookom
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: Nightly Build
>
> The contract between ViewHandler and RenderKit for creating a ResponseWriter is that the ViewHandler should suggest a list of supported contentTypes. It is the RenderKit's job to pick the appropriate one based on it's output-- not just any of them.
> In the case of Firefox, the first item it sends is 'text/xml, ....', the HtmlRenderKit in MyFaces just says, use the first item returned, so the response is set to be contentType of 'text/xml'.
> This causes issues since the browser gets a response, renders it, but treats the content with comments <!-- --> as XML-- so that means the css isn't used, and commented JavaScript isn't seen.
> This is a major blocker.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by "Martin Marinschek (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-441?page=all ]
Martin Marinschek closed MYFACES-441:
-------------------------------------
Resolution: Fixed
This should finally be done. We should still work on text/xml/xhtml support in any case.
> CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> ---------------------------------------------------------------------
>
> Key: MYFACES-441
> URL: http://issues.apache.org/jira/browse/MYFACES-441
> Project: MyFaces
> Type: Bug
> Components: JSF 1.1
> Versions: 1.0.9 beta
> Environment: Tomcat, FireFox/Mozilla Browser
> Reporter: Jacob Hookom
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: Nightly Build
>
> The contract between ViewHandler and RenderKit for creating a ResponseWriter is that the ViewHandler should suggest a list of supported contentTypes. It is the RenderKit's job to pick the appropriate one based on it's output-- not just any of them.
> In the case of Firefox, the first item it sends is 'text/xml, ....', the HtmlRenderKit in MyFaces just says, use the first item returned, so the response is set to be contentType of 'text/xml'.
> This causes issues since the browser gets a response, renders it, but treats the content with comments <!-- --> as XML-- so that means the css isn't used, and commented JavaScript isn't seen.
> This is a major blocker.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by "Jacob Hookom (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-441?page=comments#action_12319858 ]
Jacob Hookom commented on MYFACES-441:
--------------------------------------
Great! Thanks a ton!
> CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> ---------------------------------------------------------------------
>
> Key: MYFACES-441
> URL: http://issues.apache.org/jira/browse/MYFACES-441
> Project: MyFaces
> Type: Bug
> Components: JSF 1.1
> Versions: 1.0.9 beta
> Environment: Tomcat, FireFox/Mozilla Browser
> Reporter: Jacob Hookom
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: Nightly Build
>
> The contract between ViewHandler and RenderKit for creating a ResponseWriter is that the ViewHandler should suggest a list of supported contentTypes. It is the RenderKit's job to pick the appropriate one based on it's output-- not just any of them.
> In the case of Firefox, the first item it sends is 'text/xml, ....', the HtmlRenderKit in MyFaces just says, use the first item returned, so the response is set to be contentType of 'text/xml'.
> This causes issues since the browser gets a response, renders it, but treats the content with comments <!-- --> as XML-- so that means the css isn't used, and commented JavaScript isn't seen.
> This is a major blocker.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by Martin Marinschek <ma...@gmail.com>.
Yes.
please comment on the jira issue directly, else your comments will be
lost to the afterworld ;)
regards,
Martin
On 8/25/05, Alexandr J. Smirnov <sa...@demi.spb.ru> wrote:
> It's bug in most MyFaces components - script & style content produced by write() methods with <!-- --> strings, instead of writeComment();
> In last case case writer can produce right ( <!-- or <[CDATA ) markup for content.
>
> > -----Original Message-----
> > From: Jacob Hookom (JIRA) [mailto:myfaces-dev@incubator.apache.org]
> > Sent: Wednesday, August 24, 2005 7:30 PM
> > To: dev@myfaces.apache.org
> > Subject: [jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't
> > choose correct ContentType (JavaScript)
> >
> >
> > [
> > http://issues.apache.org/jira/browse/MYFACES-441?page=comments#act
> > ion_12319853 ]
> >
> > Jacob Hookom commented on MYFACES-441:
> > --------------------------------------
> >
> > If the renderkit is going to allow a content type of "xhtml",
> > then it needs to produce "xhtml" compliant JavaScript, which I
> > don't believe it's able to at this point. You are probably safe
> > returning "text/html" everytime until your renderkit is fully
> > xhtml compliant for all built-in components. Cheers!
> >
> > > CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> > > ---------------------------------------------------------------------
> > >
> > > Key: MYFACES-441
> > > URL: http://issues.apache.org/jira/browse/MYFACES-441
> > > Project: MyFaces
> > > Type: Bug
> > > Components: JSF 1.1
> > > Versions: 1.0.9 beta
> > > Environment: Tomcat, FireFox/Mozilla Browser
> > > Reporter: Jacob Hookom
> > > Assignee: Martin Marinschek
> > > Priority: Critical
> > > Fix For: Nightly Build
> >
> > >
> > > The contract between ViewHandler and RenderKit for creating a
> > ResponseWriter is that the ViewHandler should suggest a list of
> > supported contentTypes. It is the RenderKit's job to pick the
> > appropriate one based on it's output-- not just any of them.
> > > In the case of Firefox, the first item it sends is 'text/xml,
> > ....', the HtmlRenderKit in MyFaces just says, use the first item
> > returned, so the response is set to be contentType of 'text/xml'.
> > > This causes issues since the browser gets a response, renders
> > it, but treats the content with comments <!-- --> as XML-- so
> > that means the css isn't used, and commented JavaScript isn't seen.
> > > This is a major blocker.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> > http://www.atlassian.com/software/jira
> >
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Trainings in English and German
RE: [jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by "Alexandr J. Smirnov" <sa...@demi.spb.ru>.
It's bug in most MyFaces components - script & style content produced by write() methods with <!-- --> strings, instead of writeComment();
In last case case writer can produce right ( <!-- or <[CDATA ) markup for content.
> -----Original Message-----
> From: Jacob Hookom (JIRA) [mailto:myfaces-dev@incubator.apache.org]
> Sent: Wednesday, August 24, 2005 7:30 PM
> To: dev@myfaces.apache.org
> Subject: [jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't
> choose correct ContentType (JavaScript)
>
>
> [
> http://issues.apache.org/jira/browse/MYFACES-441?page=comments#act
> ion_12319853 ]
>
> Jacob Hookom commented on MYFACES-441:
> --------------------------------------
>
> If the renderkit is going to allow a content type of "xhtml",
> then it needs to produce "xhtml" compliant JavaScript, which I
> don't believe it's able to at this point. You are probably safe
> returning "text/html" everytime until your renderkit is fully
> xhtml compliant for all built-in components. Cheers!
>
> > CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> > ---------------------------------------------------------------------
> >
> > Key: MYFACES-441
> > URL: http://issues.apache.org/jira/browse/MYFACES-441
> > Project: MyFaces
> > Type: Bug
> > Components: JSF 1.1
> > Versions: 1.0.9 beta
> > Environment: Tomcat, FireFox/Mozilla Browser
> > Reporter: Jacob Hookom
> > Assignee: Martin Marinschek
> > Priority: Critical
> > Fix For: Nightly Build
>
> >
> > The contract between ViewHandler and RenderKit for creating a
> ResponseWriter is that the ViewHandler should suggest a list of
> supported contentTypes. It is the RenderKit's job to pick the
> appropriate one based on it's output-- not just any of them.
> > In the case of Firefox, the first item it sends is 'text/xml,
> ....', the HtmlRenderKit in MyFaces just says, use the first item
> returned, so the response is set to be contentType of 'text/xml'.
> > This causes issues since the browser gets a response, renders
> it, but treats the content with comments <!-- --> as XML-- so
> that means the css isn't used, and commented JavaScript isn't seen.
> > This is a major blocker.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
[jira] Commented: (MYFACES-441) CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
Posted by "Jacob Hookom (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-441?page=comments#action_12319853 ]
Jacob Hookom commented on MYFACES-441:
--------------------------------------
If the renderkit is going to allow a content type of "xhtml", then it needs to produce "xhtml" compliant JavaScript, which I don't believe it's able to at this point. You are probably safe returning "text/html" everytime until your renderkit is fully xhtml compliant for all built-in components. Cheers!
> CLONE -HTML Renderkit doesn't choose correct ContentType (JavaScript)
> ---------------------------------------------------------------------
>
> Key: MYFACES-441
> URL: http://issues.apache.org/jira/browse/MYFACES-441
> Project: MyFaces
> Type: Bug
> Components: JSF 1.1
> Versions: 1.0.9 beta
> Environment: Tomcat, FireFox/Mozilla Browser
> Reporter: Jacob Hookom
> Assignee: Martin Marinschek
> Priority: Critical
> Fix For: Nightly Build
>
> The contract between ViewHandler and RenderKit for creating a ResponseWriter is that the ViewHandler should suggest a list of supported contentTypes. It is the RenderKit's job to pick the appropriate one based on it's output-- not just any of them.
> In the case of Firefox, the first item it sends is 'text/xml, ....', the HtmlRenderKit in MyFaces just says, use the first item returned, so the response is set to be contentType of 'text/xml'.
> This causes issues since the browser gets a response, renders it, but treats the content with comments <!-- --> as XML-- so that means the css isn't used, and commented JavaScript isn't seen.
> This is a major blocker.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira