[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1367: MINIFICPP-1822 - Add alert capability

[GitBox <gi...@apache.org>]

adamdebreceni commented on code in PR #1367:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1367#discussion_r934389490


##########
libminifi/include/utils/Id.h:
##########
@@ -141,18 +142,14 @@ struct hash<org::apache::nifi::minifi::utils::Identifier> {
   size_t operator()(const org::apache::nifi::minifi::utils::Identifier& id) const noexcept {
     static_assert(sizeof(org::apache::nifi::minifi::utils::Identifier) % sizeof(size_t) == 0);
     constexpr int slices = sizeof(org::apache::nifi::minifi::utils::Identifier) / sizeof(size_t);

Review Comment:
   does the `static_assert` at linke 143 not cover these cases?



##########
libminifi/include/utils/Id.h:
##########
@@ -141,18 +142,14 @@ struct hash<org::apache::nifi::minifi::utils::Identifier> {
   size_t operator()(const org::apache::nifi::minifi::utils::Identifier& id) const noexcept {
     static_assert(sizeof(org::apache::nifi::minifi::utils::Identifier) % sizeof(size_t) == 0);
     constexpr int slices = sizeof(org::apache::nifi::minifi::utils::Identifier) / sizeof(size_t);

Review Comment:
   does the `static_assert` at line 143 not cover these cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org