You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/05/31 16:35:48 UTC

[commons-numbers] branch master updated: [NUMBERS-108] - Cleaning up Checkstyle reported issues - followup cleaning up JavaDoc, Method order etc.

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git


The following commit(s) were added to refs/heads/master by this push:
     new 5411cdc  [NUMBERS-108] - Cleaning up Checkstyle reported issues  - followup cleaning up JavaDoc, Method order etc.
     new daac9ac  Merge branch 'NUMBERS-108__karl'
5411cdc is described below

commit 5411cdc693e8f48c59448e378ea050e3633209c6
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Fri May 31 18:21:44 2019 +0200

    [NUMBERS-108] - Cleaning up Checkstyle reported issues
     - followup cleaning up JavaDoc, Method order etc.
---
 .../main/java/org/apache/commons/numbers/arrays/CosAngle.java  |  1 +
 .../org/apache/commons/numbers/arrays/LinearCombination.java   |  5 +++++
 .../main/java/org/apache/commons/numbers/arrays/SafeNorm.java  |  5 +++++
 .../commons/numbers/combinatorics/BinomialCoefficient.java     |  1 +
 .../numbers/combinatorics/BinomialCoefficientDouble.java       |  1 +
 .../org/apache/commons/numbers/combinatorics/Factorial.java    | 10 ++++++----
 .../commons/numbers/combinatorics/LogBinomialCoefficient.java  |  1 +
 .../java/org/apache/commons/numbers/core/ArithmeticUtils.java  |  8 +++++++-
 .../main/java/org/apache/commons/numbers/gamma/Digamma.java    | 10 ++++++----
 .../src/main/java/org/apache/commons/numbers/gamma/Erf.java    |  1 +
 .../java/org/apache/commons/numbers/gamma/ErfDifference.java   |  9 +++++----
 .../src/main/java/org/apache/commons/numbers/gamma/Erfc.java   |  1 +
 .../src/main/java/org/apache/commons/numbers/gamma/Gamma.java  |  7 ++++---
 .../java/org/apache/commons/numbers/gamma/InvGamma1pm1.java    |  8 +++++---
 .../main/java/org/apache/commons/numbers/gamma/InverseErf.java |  1 +
 .../java/org/apache/commons/numbers/gamma/InverseErfc.java     |  1 +
 .../org/apache/commons/numbers/gamma/LanczosApproximation.java |  9 +++++----
 .../main/java/org/apache/commons/numbers/gamma/LogBeta.java    | 10 +++++-----
 .../main/java/org/apache/commons/numbers/gamma/LogGamma.java   |  9 +++++----
 .../main/java/org/apache/commons/numbers/gamma/LogGamma1p.java |  1 +
 .../java/org/apache/commons/numbers/gamma/LogGammaSum.java     |  1 +
 .../java/org/apache/commons/numbers/gamma/RegularizedBeta.java |  7 ++++---
 .../org/apache/commons/numbers/gamma/RegularizedGamma.java     |  7 ++++---
 .../main/java/org/apache/commons/numbers/gamma/Trigamma.java   | 10 ++++++----
 24 files changed, 82 insertions(+), 42 deletions(-)

diff --git a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
index f20debf..5d17b0f 100644
--- a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
+++ b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/CosAngle.java
@@ -21,6 +21,7 @@ package org.apache.commons.numbers.arrays;
  */
 public class CosAngle {
 
+    /** Private constructor. */
     private CosAngle() {
         // intentionally empty.
     }
diff --git a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/LinearCombination.java b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/LinearCombination.java
index f28a3d8..aa53abd 100644
--- a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/LinearCombination.java
+++ b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/LinearCombination.java
@@ -43,6 +43,11 @@ public class LinearCombination {
      * only at the end, after cancellation may have occurred on high order bits
      */
 
+    /** Private constructor. */
+    private LinearCombination() {
+        // intentionally empty.
+    }
+
     /**
      * @param a Factors.
      * @param b Factors.
diff --git a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/SafeNorm.java b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/SafeNorm.java
index a04fb4d..d62a035 100644
--- a/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/SafeNorm.java
+++ b/commons-numbers-arrays/src/main/java/org/apache/commons/numbers/arrays/SafeNorm.java
@@ -27,6 +27,11 @@ public class SafeNorm {
     /** Constant. */
     private static final double R_GIANT = 1.304e+19;
 
+    /** Private constructor. */
+    private SafeNorm() {
+        // intentionally empty.
+    }
+
     /**
      * @param v Cartesian coordinates.
      * @return the 2-norm of the vector.
diff --git a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
index e44e01e..8c34df1 100644
--- a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
+++ b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficient.java
@@ -27,6 +27,7 @@ import org.apache.commons.numbers.core.ArithmeticUtils;
  */
 public class BinomialCoefficient {
 
+    /** Private constructor. */
     private BinomialCoefficient() {
         // intentionally empty.
     }
diff --git a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
index 404a56e..af543b2 100644
--- a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
+++ b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/BinomialCoefficientDouble.java
@@ -25,6 +25,7 @@ package org.apache.commons.numbers.combinatorics;
  */
 public class BinomialCoefficientDouble {
 
+    /** Private constructor. */
     private BinomialCoefficientDouble() {
         // intentionally empty.
     }
diff --git a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Factorial.java b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Factorial.java
index 78d2983..40f2332 100644
--- a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Factorial.java
+++ b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/Factorial.java
@@ -22,10 +22,6 @@ package org.apache.commons.numbers.combinatorics;
  */
 public class Factorial {
 
-    private Factorial() {
-        // intentionally empty.
-    }
-
     /** All long-representable factorials */
     static final long[] FACTORIALS = new long[] {
                        1L,                  1L,                   2L,
@@ -37,6 +33,11 @@ public class Factorial {
         6402373705728000L, 121645100408832000L, 2432902008176640000L
     };
 
+    /** Private constructor. */
+    private Factorial() {
+        // intentionally empty.
+    }
+
     /**
      * Computes the factorial of {@code n}.
      *
@@ -55,4 +56,5 @@ public class Factorial {
 
         return FACTORIALS[n];
     }
+
 }
diff --git a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficient.java b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficient.java
index 993c577..2b016df 100644
--- a/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficient.java
+++ b/commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogBinomialCoefficient.java
@@ -25,6 +25,7 @@ package org.apache.commons.numbers.combinatorics;
  */
 public class LogBinomialCoefficient {
 
+    /** Private constructor. */
     private LogBinomialCoefficient() {
         // intentionally empty.
     }
diff --git a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java
index aa1bb7b..633dd3d 100644
--- a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java
+++ b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/ArithmeticUtils.java
@@ -26,17 +26,23 @@ import java.text.MessageFormat;
  */
 public final class ArithmeticUtils {
 
+    /** Overflow addition exception message. */
     private static final String OVERFLOW_IN_ADDITION_MESSAGE = "overflow in addition: {0} + {1}";
+    /** Overflow gcd exception message for 2^31. */
     private static final String OVERFLOW_GCD_MESSAGE_2_POWER_31 = "overflow: gcd({0}, {1}) is 2^31";
+    /** Overflow gcd exception message for 2^63. */
     private static final String OVERFLOW_GCD_MESSAGE_2_POWER_63 = "overflow: gcd({0}, {1}) is 2^63";
+    /** Overflow subtraction exception message. */
     private static final String OVERFLOW_IN_SUBTRACTION_MESSAGE = "overflow in subtraction: {0} + {1}";
 
+    /** Negative exponent exception message part 1 */
     private static final String NEGATIVE_EXPONENT_1 = "negative exponent ({";
+    /** Negative exponent exception message part 2 */
     private static final String NEGATIVE_EXPONENT_2 = "})";
 
     /** Private constructor. */
     private ArithmeticUtils() {
-        super();
+        // intentionally empty.
     }
 
     /**
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Digamma.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Digamma.java
index f6867c1..e30a1ff 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Digamma.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Digamma.java
@@ -28,12 +28,9 @@ package org.apache.commons.numbers.gamma;
  */
 public class Digamma {
 
-    private Digamma() {
-        // intentional empty.
-    }
-
     /** <a href="http://en.wikipedia.org/wiki/Euler-Mascheroni_constant">Euler-Mascheroni constant</a>. */
     private static final double GAMMA = 0.577215664901532860606512090082;
+
     /** C limit. */
     private static final double C_LIMIT = 49;
     /** S limit. */
@@ -45,6 +42,11 @@ public class Digamma {
     /** Fraction. */
     private static final double F_M1_252 = -1d / 252;
 
+    /** Private constructor. */
+    private Digamma() {
+        // intentional empty.
+    }
+
     /**
      * Computes the digamma function.
      *
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erf.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erf.java
index 2795398..eba9a7c 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erf.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erf.java
@@ -21,6 +21,7 @@ package org.apache.commons.numbers.gamma;
  */
 public class Erf {
 
+    /** Private constructor. */
     private Erf() {
         // intenitonal empty.
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/ErfDifference.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/ErfDifference.java
index 636dd49..2c2e70d 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/ErfDifference.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/ErfDifference.java
@@ -21,10 +21,6 @@ package org.apache.commons.numbers.gamma;
  */
 public class ErfDifference {
 
-    private ErfDifference() {
-        // intentionally empty.
-    }
-
     /**
      * This number solves {@code erf(x) = 0.5} within 1 ulp.
      * More precisely, the current implementations of
@@ -38,6 +34,11 @@ public class ErfDifference {
      */
     private static final double X_CRIT = 0.4769362762044697;
 
+    /** Private constructor. */
+    private ErfDifference() {
+        // intentionally empty.
+    }
+
     /**
      * The implementation uses either {@link Erf} or {@link Erfc},
      * depending on which provides the most precise result.
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erfc.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erfc.java
index 54e8550..b5b7752 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erfc.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Erfc.java
@@ -21,6 +21,7 @@ package org.apache.commons.numbers.gamma;
  */
 public class Erfc {
 
+    /** Private constructor. */
     private Erfc() {
         // intentionally empty.
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Gamma.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Gamma.java
index dc26f28..9b1c5aa 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Gamma.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Gamma.java
@@ -32,13 +32,14 @@ package org.apache.commons.numbers.gamma;
  */
 public class Gamma {
 
+    /** &radic;(2&pi;). */
+    private static final double SQRT_TWO_PI = 2.506628274631000502;
+
+    /** Private constructor. */
     private Gamma() {
         // intentionally empty.
     }
 
-    /** &radic;(2&pi;). */
-    private static final double SQRT_TWO_PI = 2.506628274631000502;
-
     /**
      * Computes the value of \( \Gamma(x) \).
      * <p>
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InvGamma1pm1.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InvGamma1pm1.java
index f936c7c..f98fed5 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InvGamma1pm1.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InvGamma1pm1.java
@@ -23,9 +23,6 @@ package org.apache.commons.numbers.gamma;
  */
 class InvGamma1pm1 {
 
-    private InvGamma1pm1() {
-        // intentionally empty.
-    }
 
     /*
      * Constants copied from DGAM1 in the NSWC library.
@@ -103,6 +100,11 @@ class InvGamma1pm1 {
     /** The constant {@code C13} defined in {@code DGAM1}. */
     private static final double INV_GAMMA1P_M1_C13 = -.205633841697760710345015413002057E-06;
 
+    /** Private constructor. */
+    private InvGamma1pm1() {
+        // intentionally empty.
+    }
+
     /**
      * Computes the function \( \frac{1}{\Gamma(1 + x)} - 1 \) for {@code -0.5 <= x <= 1.5}.
      *
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErf.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErf.java
index 8295800..6944e38 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErf.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErf.java
@@ -28,6 +28,7 @@ package org.apache.commons.numbers.gamma;
  */
 public class InverseErf {
 
+    /** Private constructor. */
     private InverseErf() {
         // intentionally empty.
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErfc.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErfc.java
index 92ff0ea..8cef231 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErfc.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/InverseErfc.java
@@ -28,6 +28,7 @@ package org.apache.commons.numbers.gamma;
  */
 public class InverseErfc {
 
+    /** Private constructor. */
     private InverseErfc() {
         // intentional empty.
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LanczosApproximation.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LanczosApproximation.java
index f2dc5ee..5440d47 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LanczosApproximation.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LanczosApproximation.java
@@ -33,10 +33,6 @@ package org.apache.commons.numbers.gamma;
  */
 public class LanczosApproximation {
 
-    private LanczosApproximation() {
-        // intentional empty.
-    }
-
     /** \( g = \frac{607}{128} \). */
     private static final double LANCZOS_G = 607d / 128d;
     /** Lanczos coefficients. */
@@ -58,6 +54,11 @@ public class LanczosApproximation {
         .36899182659531622704e-5,
     };
 
+    /** Private constructor. */
+    private LanczosApproximation() {
+        // intentional empty.
+    }
+
     /**
      * Computes the Lanczos approximation.
      *
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogBeta.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogBeta.java
index 11b2b27..b394300 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogBeta.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogBeta.java
@@ -24,11 +24,6 @@ package org.apache.commons.numbers.gamma;
  */
 public class LogBeta {
 
-    /** Private constructor. */
-    private LogBeta() {
-        // intentional empty.
-    }
-
 
     /** The constant value of ½log 2π. */
     private static final double HALF_LOG_TWO_PI = 0.9189385332046727;
@@ -71,6 +66,11 @@ public class LogBeta {
         .171348014966398575409015466667E-22
     };
 
+    /** Private constructor. */
+    private LogBeta() {
+        // intentional empty.
+    }
+
     /**
      * Returns the value of Δ(b) - Δ(a + b), with 0 ≤ a ≤ b and b ≥ 10. Based
      * on equations (26), (27) and (28) in Didonato and Morris (1992).
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma.java
index d50f06b..4e491be 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma.java
@@ -23,15 +23,16 @@ package org.apache.commons.numbers.gamma;
  */
 public class LogGamma {
 
-    private LogGamma() {
-        // intentionally empty.
-    }
-
     /** Lanczos constant. */
     private static final double LANCZOS_G = 607d / 128d;
     /** Performance. */
     private static final double HALF_LOG_2_PI = 0.5 * Math.log(2.0 * Math.PI);
 
+    /** Private constructor. */
+    private LogGamma() {
+        // intentionally empty.
+    }
+
     /**
      * Computes the function \( \ln \Gamma(x) \) for {@code x >= 0}.
      *
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma1p.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma1p.java
index 74b2935..95da30c 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma1p.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGamma1p.java
@@ -23,6 +23,7 @@ package org.apache.commons.numbers.gamma;
  */
 class LogGamma1p {
 
+    /** Private constructor. */
     private LogGamma1p() {
         // intentionally empty
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGammaSum.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGammaSum.java
index 5d957fd..b437b35 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGammaSum.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/LogGammaSum.java
@@ -24,6 +24,7 @@ package org.apache.commons.numbers.gamma;
  */
 class LogGammaSum {
 
+    /** Private constructor. */
     private LogGammaSum() {
         // intentionally empty
     }
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedBeta.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedBeta.java
index 61f6218..f93a697 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedBeta.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedBeta.java
@@ -27,13 +27,14 @@ import org.apache.commons.numbers.fraction.ContinuedFraction;
  */
 public class RegularizedBeta {
 
+    /** Maximum allowed numerical error. */
+    private static final double DEFAULT_EPSILON = 1e-14;
+
+    /** Private constructor. */
     private RegularizedBeta() {
         // intentionally empty.
     }
 
-    /** Maximum allowed numerical error. */
-    private static final double DEFAULT_EPSILON = 1e-14;
-
     /**
      * Computes the value of the
      * <a href="http://mathworld.wolfram.com/RegularizedBetaFunction.html">
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedGamma.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedGamma.java
index 9fa1ad8..8451196 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedGamma.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/RegularizedGamma.java
@@ -26,13 +26,14 @@ import org.apache.commons.numbers.fraction.ContinuedFraction;
  */
 public class RegularizedGamma {
 
+    /** Maximum allowed numerical error. */
+    private static final double DEFAULT_EPSILON = 1e-15;
+
+    /** Private constructor. */
     private RegularizedGamma() {
         // intentionally empty.
     }
 
-    /** Maximum allowed numerical error. */
-    private static final double DEFAULT_EPSILON = 1e-15;
-
     /**
      * \( P(a, x) \) <a href="http://mathworld.wolfram.com/RegularizedGammaFunction.html">
      * regularized Gamma function</a>.
diff --git a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Trigamma.java b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Trigamma.java
index 7ea4add..487b6c3 100644
--- a/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Trigamma.java
+++ b/commons-numbers-gamma/src/main/java/org/apache/commons/numbers/gamma/Trigamma.java
@@ -24,12 +24,9 @@ package org.apache.commons.numbers.gamma;
  */
 public class Trigamma {
 
-    private Trigamma() {
-        // intentional empty.
-    }
-
     /** C limit. */
     private static final double C_LIMIT = 49;
+
     /** S limit. */
     private static final double S_LIMIT = 1e-5;
     /** Fraction. */
@@ -39,6 +36,11 @@ public class Trigamma {
     /** Fraction. */
     private static final double F_1_42 = 1d / 42;
 
+    /** Private constructor. */
+    private Trigamma() {
+        // intentional empty.
+    }
+
     /**
      * Computes the trigamma function.
      *