You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by ba...@apache.org on 2008/01/14 17:08:52 UTC
svn commit: r611842 -
/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
Author: barrettj
Date: Mon Jan 14 08:08:43 2008
New Revision: 611842
URL: http://svn.apache.org/viewvc?rev=611842&view=rev
Log:
The first WSDL port should be returned (by WSDL4J) but it is not. Depending on the JDK in use either the 2nd (Sun JDK) or 3rd (IBM JDK) is returned.
Added a comment to that affect and removed all the commented out and FIXME comments except the one for the 1st port. That assert is commented out with a FIXME
comment.
Modified:
webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
Modified: webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java?rev=611842&r1=611841&r2=611842&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java (original)
+++ webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java Mon Jan 14 08:08:43 2008
@@ -303,9 +303,8 @@
String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
assertNotNull(endpointAddress1);
// FIXME: We should get the first port in the WSDL, but that isn't working
+ // Depending on the JDK in use, the 2nd or 3rd port is returned
// assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
- // FIXME: This isnt working either
-// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
// Set a prefered port and create the service
QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
@@ -348,9 +347,8 @@
String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
assertNotNull(endpointAddress1);
// FIXME: We should get the first port in the WSDL, but that isn't working
+ // Depending on the JDK in use, the 2nd or 3rd port is returned
// assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
- // FIXME: This isnt working either
-// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
// Set a prefered port and create the service
QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
@@ -388,9 +386,8 @@
String endpointAddress3 = (String) requestContext3.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
assertNotNull(endpointAddress1);
// FIXME: We should get the first port in the WSDL, but that isn't working
+ // Depending on the JDK in use, the 2nd or 3rd port is returned
// assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
- // FIXME: This isnt working either
-// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
} finally {
ClientMetadataTest.restoreOriginalFactory();
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org
Re: svn commit: r611842 - /webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
Posted by Davanum Srinivas <da...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Perfect! thanks.
- -- dims
Jeremy Hughes wrote:
| On 14/01/2008, Davanum Srinivas <da...@gmail.com> wrote:
| I did some debugging, looks like javax.wsdl.Service's getPorts() returns a map. the order of items in the iterator on
| that map is non-deterministic. internally com.ibm.wsdl.ServiceImpl uses a HashMap. Maybe we can bug the WSDL4J folks to
| change that to a LinkedHashMap? :)
|
|> Sounds reasonable ... WSDL4J was written for Java 1.3 but now depends
|> on Java 1.4 LinkedHashMap was introduced in 1.4.
|
| thanks,
| dims
|
| barrettj@apache.org wrote:
| | Author: barrettj
| | Date: Mon Jan 14 08:08:43 2008
| | New Revision: 611842
| |
| | URL: http://svn.apache.org/viewvc?rev=611842&view=rev
| | Log:
| | The first WSDL port should be returned (by WSDL4J) but it is not. Depending on the JDK in use either the 2nd (Sun
| JDK) or 3rd (IBM JDK) is returned.
| | Added a comment to that affect and removed all the commented out and FIXME comments except the one for the 1st port.
| That assert is commented out with a FIXME
| | comment.
| |
| | Modified:
| | webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
| |
| | Modified: webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
| | URL:
|
http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java?rev=611842&r1=611841&r2=611842&view=diff
| | ==============================================================================
| | --- webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java (original)
| | +++ webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java Mon Jan 14
| 08:08:43 2008
| | @@ -303,9 +303,8 @@
| | String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| | assertNotNull(endpointAddress1);
| | // FIXME: We should get the first port in the WSDL, but that isn't working
| | + // Depending on the JDK in use, the 2nd or 3rd port is returned
| | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| | - // FIXME: This isnt working either
| | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
| |
| | // Set a prefered port and create the service
| | QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
| | @@ -348,9 +347,8 @@
| | String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| | assertNotNull(endpointAddress1);
| | // FIXME: We should get the first port in the WSDL, but that isn't working
| | + // Depending on the JDK in use, the 2nd or 3rd port is returned
| | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| | - // FIXME: This isnt working either
| | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
| |
| | // Set a prefered port and create the service
| | QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
| | @@ -388,9 +386,8 @@
| | String endpointAddress3 = (String) requestContext3.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| | assertNotNull(endpointAddress1);
| | // FIXME: We should get the first port in the WSDL, but that isn't working
| | + // Depending on the JDK in use, the 2nd or 3rd port is returned
| | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| | - // FIXME: This isnt working either
| | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
| |
| | } finally {
| | ClientMetadataTest.restoreOriginalFactory();
| |
| |
| |
| | ---------------------------------------------------------------------
| | To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
| | For additional commands, e-mail: axis-cvs-help@ws.apache.org
| |
|>
- ---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
|>
|>
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
| For additional commands, e-mail: axis-dev-help@ws.apache.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
iD8DBQFHi5Y7gNg6eWEDv1kRAlijAJ4ykcNk1u7sELlsfRU94AmSCUdUPwCgqo9Y
ADROwxyX96XsFZ+dTa3EH2U=
=EUUP
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: svn commit: r611842 - /webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
Posted by Jeremy Hughes <hu...@apache.org>.
On 14/01/2008, Davanum Srinivas <da...@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I did some debugging, looks like javax.wsdl.Service's getPorts() returns a map. the order of items in the iterator on
> that map is non-deterministic. internally com.ibm.wsdl.ServiceImpl uses a HashMap. Maybe we can bug the WSDL4J folks to
> change that to a LinkedHashMap? :)
Sounds reasonable ... WSDL4J was written for Java 1.3 but now depends
on Java 1.4 LinkedHashMap was introduced in 1.4.
>
> thanks,
> dims
>
> barrettj@apache.org wrote:
> | Author: barrettj
> | Date: Mon Jan 14 08:08:43 2008
> | New Revision: 611842
> |
> | URL: http://svn.apache.org/viewvc?rev=611842&view=rev
> | Log:
> | The first WSDL port should be returned (by WSDL4J) but it is not. Depending on the JDK in use either the 2nd (Sun
> JDK) or 3rd (IBM JDK) is returned.
> | Added a comment to that affect and removed all the commented out and FIXME comments except the one for the 1st port.
> That assert is commented out with a FIXME
> | comment.
> |
> | Modified:
> | webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
> |
> | Modified: webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
> | URL:
> http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java?rev=611842&r1=611841&r2=611842&view=diff
> | ==============================================================================
> | --- webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java (original)
> | +++ webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java Mon Jan 14
> 08:08:43 2008
> | @@ -303,9 +303,8 @@
> | String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
> | assertNotNull(endpointAddress1);
> | // FIXME: We should get the first port in the WSDL, but that isn't working
> | + // Depending on the JDK in use, the 2nd or 3rd port is returned
> | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
> | - // FIXME: This isnt working either
> | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
> |
> | // Set a prefered port and create the service
> | QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
> | @@ -348,9 +347,8 @@
> | String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
> | assertNotNull(endpointAddress1);
> | // FIXME: We should get the first port in the WSDL, but that isn't working
> | + // Depending on the JDK in use, the 2nd or 3rd port is returned
> | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
> | - // FIXME: This isnt working either
> | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
> |
> | // Set a prefered port and create the service
> | QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
> | @@ -388,9 +386,8 @@
> | String endpointAddress3 = (String) requestContext3.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
> | assertNotNull(endpointAddress1);
> | // FIXME: We should get the first port in the WSDL, but that isn't working
> | + // Depending on the JDK in use, the 2nd or 3rd port is returned
> | // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
> | - // FIXME: This isnt working either
> | -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
> |
> | } finally {
> | ClientMetadataTest.restoreOriginalFactory();
> |
> |
> |
> | ---------------------------------------------------------------------
> | To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> | For additional commands, e-mail: axis-cvs-help@ws.apache.org
> |
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Cygwin)
>
> iD8DBQFHi4wNgNg6eWEDv1kRAlKBAJwKkdJFsSLJKneF3S0EFFCSFIkVHgCgn9Es
> 91qeoTMUEFuKeb1UGsgt6x4=
> =7xlH
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
Re: svn commit: r611842 - /webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
Posted by Davanum Srinivas <da...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I did some debugging, looks like javax.wsdl.Service's getPorts() returns a map. the order of items in the iterator on
that map is non-deterministic. internally com.ibm.wsdl.ServiceImpl uses a HashMap. Maybe we can bug the WSDL4J folks to
change that to a LinkedHashMap? :)
thanks,
dims
barrettj@apache.org wrote:
| Author: barrettj
| Date: Mon Jan 14 08:08:43 2008
| New Revision: 611842
|
| URL: http://svn.apache.org/viewvc?rev=611842&view=rev
| Log:
| The first WSDL port should be returned (by WSDL4J) but it is not. Depending on the JDK in use either the 2nd (Sun
JDK) or 3rd (IBM JDK) is returned.
| Added a comment to that affect and removed all the commented out and FIXME comments except the one for the 1st port.
That assert is commented out with a FIXME
| comment.
|
| Modified:
| webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
|
| Modified: webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java
| URL:
http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java?rev=611842&r1=611841&r2=611842&view=diff
| ==============================================================================
| --- webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java (original)
| +++ webservices/axis2/trunk/java/modules/jaxws/test/org/apache/axis2/jaxws/spi/ClientMetadataPortTest.java Mon Jan 14
08:08:43 2008
| @@ -303,9 +303,8 @@
| String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| assertNotNull(endpointAddress1);
| // FIXME: We should get the first port in the WSDL, but that isn't working
| + // Depending on the JDK in use, the 2nd or 3rd port is returned
| // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| - // FIXME: This isnt working either
| -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
|
| // Set a prefered port and create the service
| QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
| @@ -348,9 +347,8 @@
| String endpointAddress1 = (String) requestContext1.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| assertNotNull(endpointAddress1);
| // FIXME: We should get the first port in the WSDL, but that isn't working
| + // Depending on the JDK in use, the 2nd or 3rd port is returned
| // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| - // FIXME: This isnt working either
| -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
|
| // Set a prefered port and create the service
| QName portQN2 = new QName(namespaceURI, multiPortWsdl_portLocalPart2);
| @@ -388,9 +386,8 @@
| String endpointAddress3 = (String) requestContext3.get(BindingProvider.ENDPOINT_ADDRESS_PROPERTY);
| assertNotNull(endpointAddress1);
| // FIXME: We should get the first port in the WSDL, but that isn't working
| + // Depending on the JDK in use, the 2nd or 3rd port is returned
| // assertTrue(endpointAddress.endsWith(multiPortWsdl_portLocalPart1));
| - // FIXME: This isnt working either
| -// assertTrue(endpointAddress1.endsWith(multiPortWsdl_portLocalPart3));
|
| } finally {
| ClientMetadataTest.restoreOriginalFactory();
|
|
|
| ---------------------------------------------------------------------
| To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
| For additional commands, e-mail: axis-cvs-help@ws.apache.org
|
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
iD8DBQFHi4wNgNg6eWEDv1kRAlKBAJwKkdJFsSLJKneF3S0EFFCSFIkVHgCgn9Es
91qeoTMUEFuKeb1UGsgt6x4=
=7xlH
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org