You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/10/01 12:32:48 UTC

[GitHub] [felix-dev] daniele-moro opened a new pull request #53: [FELIX-6340] Resolve possible NPE for filter in Scanner

daniele-moro opened a new pull request #53:
URL: https://github.com/apache/felix-dev/pull/53


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [felix-dev] jbonofre merged pull request #53: [FELIX-6340] Resolve possible NPE for filter in Scanner

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #53:
URL: https://github.com/apache/felix-dev/pull/53


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [felix-dev] Andrea-Campanella edited a comment on pull request #53: [FELIX-6340] Resolve possible NPE for filter in Scanner

Posted by GitBox <gi...@apache.org>.
Andrea-Campanella edited a comment on pull request #53:
URL: https://github.com/apache/felix-dev/pull/53#issuecomment-704996029


   I can confirm that the filter being null in the `andreacampanella/voltha-onos:felix-fix` is the culprit of the NPE I was seeing in my karaf 4.2.9 deployment
   ```
   2020-10-07T15:13:23,789 | ERROR | fileinstall-/root/onos/apache-karaf-4.2.9/deploy | fileinstall                      | 10 - org.apache.felix.fileinstall - 3.6.6 | In main loop, we have serious trouble
   java.lang.NullPointerException: null
           at org.apache.felix.fileinstall.internal.Scanner.processFiles(Scanner.java:158) ~[!/:3.6.6]
           at org.apache.felix.fileinstall.internal.Scanner.scan(Scanner.java:131) ~[!/:3.6.6]
           at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:311) [!/:3.6.6]
   ```
   adding the following line `felix.fileinstall.filter=*.jar` to the file removes the NPE by ensuring the filter is never null. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [felix-dev] Andrea-Campanella commented on pull request #53: [FELIX-6340] Resolve possible NPE for filter in Scanner

Posted by GitBox <gi...@apache.org>.
Andrea-Campanella commented on pull request #53:
URL: https://github.com/apache/felix-dev/pull/53#issuecomment-704996029


   I can confirm that the filter being null in the `andreacampanella/voltha-onos:felix-fix` is the culprit of the NPE I was seeing in my karaf 4.2.9 deployment
   ```
   2020-10-07T15:13:23,789 | ERROR | fileinstall-/root/onos/apache-karaf-4.2.9/deploy | fileinstall                      | 10 - org.apache.felix.fileinstall - 3.6.6 | In main loop, we have serious trouble
   java.lang.NullPointerException: null
           at org.apache.felix.fileinstall.internal.Scanner.processFiles(Scanner.java:158) ~[!/:3.6.6]
           at org.apache.felix.fileinstall.internal.Scanner.scan(Scanner.java:131) ~[!/:3.6.6]
           at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:311) [!/:3.6.6]
   ```
   adding the following line `felix.fileinstall.filter=*.jar` to the file removes the NPE. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org