You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "AaronGhebretinsae (via GitHub)" <gi...@apache.org> on 2024/01/24 19:41:18 UTC
[PR] [ISSUE #3903] [Enhancement] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
AaronGhebretinsae opened a new pull request, #4757:
URL: https://github.com/apache/eventmesh/pull/4757
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #issue_id
### Motivation
I am currently new to open source contributing and would like to gain experience solving issues and navigating git in order to become a better contributor.
### Modifications
-Added appropriate getters and setters for HeartbeatEntity class in HeartbeatRequestBody.java.
-Updated EventMeshHttpConsumer.java to access aforementioned variables using correct setters.
-Updated HeartbeatProcessor.java to access aforementioned variables using correct getters.
### Documentation
At eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java line 70-75
At eventmesh-sdk
java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java line 120,121
At eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java line 115,116
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm merged PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3903] [Enhancement] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757#discussion_r1465763641
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java:
##########
@@ -66,12 +66,46 @@ public Map<String, Object> toMap() {
return map;
}
- @ToString
+ @Data
public static class HeartbeatEntity {
- public String topic;
- public String serviceId;
- public String url;
- public String instanceId;
+ private String topic;
+ private String serviceId;
+ private String url;
+ private String instanceId;
+
+ public String getTopic() {
+ return topic;
+ }
+
+ public void setTopic(String topic) {
+ this.topic = topic;
+ }
+
+ public String getServiceId() {
+ return serviceId;
+ }
+
+ public void setServiceId(String serviceId) {
+ this.serviceId = serviceId;
+ }
+
+ public String getUrl() {
+ return url;
+ }
+
+ public void setUrl(String url) {
+ this.url = url;
+ }
+
+ public String getInstanceId() {
+ return instanceId;
+ }
+
+ public void setInstanceId(String instanceId) {
+ this.instanceId = instanceId;
+ }
Review Comment:
This code is unnecessary. because you has used the `@Data` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3903] [Enhancement] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
Posted by "AaronGhebretinsae (via GitHub)" <gi...@apache.org>.
AaronGhebretinsae commented on code in PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757#discussion_r1466750069
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java:
##########
@@ -66,12 +66,46 @@ public Map<String, Object> toMap() {
return map;
}
- @ToString
+ @Data
public static class HeartbeatEntity {
- public String topic;
- public String serviceId;
- public String url;
- public String instanceId;
+ private String topic;
+ private String serviceId;
+ private String url;
+ private String instanceId;
+
+ public String getTopic() {
+ return topic;
+ }
+
+ public void setTopic(String topic) {
+ this.topic = topic;
+ }
+
+ public String getServiceId() {
+ return serviceId;
+ }
+
+ public void setServiceId(String serviceId) {
+ this.serviceId = serviceId;
+ }
+
+ public String getUrl() {
+ return url;
+ }
+
+ public void setUrl(String url) {
+ this.url = url;
+ }
+
+ public String getInstanceId() {
+ return instanceId;
+ }
+
+ public void setInstanceId(String instanceId) {
+ this.instanceId = instanceId;
+ }
Review Comment:
I removed the extraneous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3903] [Enhancement] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
Posted by "AaronGhebretinsae (via GitHub)" <gi...@apache.org>.
AaronGhebretinsae commented on PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757#issuecomment-1910739993
I have also linked the PR to the target issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBody] (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757#issuecomment-1911257911
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `26 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`e837f34`)](https://app.codecov.io/gh/apache/eventmesh/commit/e837f34c028541f10acc8b455879d23850831f43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.59% compared to head [(`a22b0c4`)](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.60%.
> Report is 6 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...eventmesh/meta/etcd/service/EtcdCustomService.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLW1ldGEvZXZlbnRtZXNoLW1ldGEtZXRjZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL21ldGEvZXRjZC9zZXJ2aWNlL0V0Y2RDdXN0b21TZXJ2aWNlLmphdmE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...tor/file/source/connector/FileSourceConnector.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvZXZlbnRtZXNoLWNvbm5lY3Rvci1maWxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2ZpbGUvc291cmNlL2Nvbm5lY3Rvci9GaWxlU291cmNlQ29ubmVjdG9yLmphdmE=) | 75.86% | [5 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rotocol/http/body/client/HeartbeatRequestBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvY2xpZW50L0hlYXJ0YmVhdFJlcXVlc3RCb2R5LmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...re/protocol/http/processor/HeartBeatProcessor.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sh/client/http/consumer/EventMeshHttpConsumer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNka3MvZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvY29uc3VtZXIvRXZlbnRNZXNoSHR0cENvbnN1bWVyLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ctor/file/source/config/SourceConnectorConfig.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvZXZlbnRtZXNoLWNvbm5lY3Rvci1maWxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL2ZpbGUvc291cmNlL2NvbmZpZy9Tb3VyY2VDb25uZWN0b3JDb25maWcuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...h/webhook/receive/storage/WebhookFileListener.java](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXdlYmhvb2svZXZlbnRtZXNoLXdlYmhvb2stcmVjZWl2ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3dlYmhvb2svcmVjZWl2ZS9zdG9yYWdlL1dlYmhvb2tGaWxlTGlzdGVuZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
Coverage 17.59% 17.60%
- Complexity 1774 1783 +9
==========================================
Files 797 805 +8
Lines 29786 29920 +134
Branches 2573 2579 +6
==========================================
+ Hits 5242 5266 +24
- Misses 24063 24169 +106
- Partials 481 485 +4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4757?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org