You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2019/02/03 20:44:36 UTC

[jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

Notably this adds support for inline suppressions.  Release notes:

https://github.com/gaul/modernizer-maven-plugin/releases
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1272

-- Commit Summary --

  * Upgrade to modernizer-maven-plugin 1.8.0

-- File Changes --

    M core/pom.xml (5)
    M core/src/main/java/org/jclouds/functions/ExpandProperties.java (3)
    M project/pom.xml (14)
    M resources/modernizer_exclusions.txt (2)
    M scriptbuilder/pom.xml (5)
    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/functionloader/osgi/BundleFunctionLoader.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1272.patch
https://github.com/jclouds/jclouds/pull/1272.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1272

Re: [jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

Posted by Ignasi Barrera <no...@github.com>.

Hmmm dows it allow to fork again and keep 2 different forks?
If not, another opttion is to push all your branches to the ASF remote and open the PRs from there?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1272#issuecomment-460088062

Re: [jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

Posted by Andrew Gaul <no...@github.com>.

I'm a little confused why I can't open PRs against the apache repo.  Maybe I need to delete my fork and refork the apache repo?  Although then I'll lose my open PRs here...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1272#issuecomment-460087790

Re: [jclouds/jclouds] Upgrade to modernizer-maven-plugin 1.8.0 (#1272)

Posted by Ignasi Barrera <no...@github.com>.

nacx approved this pull request.

Lgtm.
Mind reopening against the Apache org repo as PR builds are configured there now?
Not a big deal. Feel free to merge directly anyway :)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1272#pullrequestreview-199404886