You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/11/16 18:54:32 UTC
[incubator-superset] branch hugh/SO-1117-modal updated: working
dataset with input box
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/SO-1117-modal
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/hugh/SO-1117-modal by this push:
new 711c5ac working dataset with input box
711c5ac is described below
commit 711c5ac20c9eca2a50a65cdf8bc71eaeedb9ee3f
Author: hughhhh <hu...@gmail.com>
AuthorDate: Mon Nov 16 10:53:52 2020 -0800
working dataset with input box
---
superset-frontend/src/SqlLab/components/ResultSet.tsx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx
index c8cf1f2..5129939 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx
@@ -101,6 +101,7 @@ export default class ResultSet extends React.PureComponent<
);
this.handleSaveInDataset = this.handleSaveInDataset.bind(this);
this.handleHideSaveModal = this.handleHideSaveModal.bind(this);
+ this.handleDatasetNameChange = this.handleDatasetNameChange.bind(this);
}
componentDidMount() {
@@ -194,7 +195,7 @@ export default class ResultSet extends React.PureComponent<
sql,
dbId,
templateParams,
- datasourceName: 'hmiles.test_dataset_2',
+ datasourceName: this.state.newSaveDatasetName,
columns: selectedColumns,
}).then(data => {
console.log(data);
@@ -206,6 +207,7 @@ export default class ResultSet extends React.PureComponent<
handleDatasetNameChange(e) {
console.log(e.target.value)
+ this.setState({ newSaveDatasetName: e.target.value })
}
handleHideSaveModal() {