You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/28 00:45:24 UTC

[GitHub] [pulsar-client-node] hrsakai opened a new pull request #117: Add github actions

hrsakai opened a new pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117


   Use github actions for precommit job.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] hrsakai commented on a change in pull request #117: Add github actions

Posted by GitBox <gi...@apache.org>.
hrsakai commented on a change in pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117#discussion_r480546074



##########
File path: .github/workflows/nodejs.yml
##########
@@ -0,0 +1,13 @@
+name: Node.js
+on: [pull_request]
+jobs:
+  build:
+    name: Build
+    runs-on: ubuntu-latest

Review comment:
       I read the documents for self-hosted runners.
   There are things to consider(security,server,etc), so we would like to consider self-hosted runners again in the future as needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] massakam commented on a change in pull request #117: Add github actions

Posted by GitBox <gi...@apache.org>.
massakam commented on a change in pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117#discussion_r479023993



##########
File path: .github/workflows/nodejs.yml
##########
@@ -0,0 +1,13 @@
+name: Node.js
+on: [pull_request]
+jobs:
+  build:
+    name: Build
+    runs-on: ubuntu-latest

Review comment:
       Is it not possible to use the `apachepulsar/pulsar-build` image directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] massakam merged pull request #117: Add github actions

Posted by GitBox <gi...@apache.org>.
massakam merged pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] okuryu commented on a change in pull request #117: Add github actions

Posted by GitBox <gi...@apache.org>.
okuryu commented on a change in pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117#discussion_r479346466



##########
File path: .github/workflows/nodejs.yml
##########
@@ -0,0 +1,13 @@
+name: Node.js
+on: [pull_request]
+jobs:
+  build:
+    name: Build
+    runs-on: ubuntu-latest

Review comment:
       You can probably do that with self-hosted runners.
   https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-node] hrsakai commented on a change in pull request #117: Add github actions

Posted by GitBox <gi...@apache.org>.
hrsakai commented on a change in pull request #117:
URL: https://github.com/apache/pulsar-client-node/pull/117#discussion_r479827873



##########
File path: .github/workflows/nodejs.yml
##########
@@ -0,0 +1,13 @@
+name: Node.js
+on: [pull_request]
+jobs:
+  build:
+    name: Build
+    runs-on: ubuntu-latest

Review comment:
       @massakam 
   By default, it seems that only the virtual environments listed in the table on the following page can be used.
   https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on
   
   @okuryu 
   Thank you for your comment.
   I will confirm self-hosted runners.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org