You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/11 01:19:09 UTC
[GitHub] [apisix-website] juzhiyuan opened a new pull request, #1148: feat: remove canvas & add schema
juzhiyuan opened a new pull request, #1148:
URL: https://github.com/apache/apisix-website/pull/1148
Changes:
[x] added structured schema (global)
[x] remove Canvas to improve visit performace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] github-actions[bot] commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152830377
<!-- NETLIFY DEPLOY COMMENT GENERATED BY ACTIONS_NETLIFY - APP ID SHA256: 4a1e2936f4b00e970c8b5babdfe5b33e6e83e97b6f6d6dda75b1fe8399056321 -->
🚀 Deployed on https://62a3f06334343a3fff57aa16--apache-apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1154645588
Hi @1502shivam-singh, thanks for your explanation, and I agree.
> Or if anyone else could contribute in this regard, most welcome.
I know @SkyeYoung is also good at design style 😄 (but he is busy fixing some issues on the website); you two can communicate 😊 and I will close this PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152916298
> With Canvas -
> Without Canvas -
Not a performance boost tbh (even if lighthouse might not be the most reliable). Also, the return from this big change isn't the most beneficial.
About performance issues, just to mention here, I had created a system to stop rendering on both canvases when they were not visible on the browser viewport, to squeeze out the most performance boost.
So, **I won't recommend** this change to take place, as it does more harm than good to the overall visual style and doesn't provide a huge chunk of performance boost anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152959159
> 1. Visitors report that the two canvas sections don't have a special meaning. I don't have better ideas, so I removed them in this PR.
I can work on improving the content displayed on the canvas in the "Build API Gateway together" section (It was the only rushed element in the redesign) I can create a custom motion graphic to replace it maybe, and add it as a lottie. But this would take some time, need to keep it till then 😅 Or if anyone else could contribute in this regard, most welcome.
> Do you have ideas to improve the performance?
So I went back and tried to analyze the performance pre-redesign through web archive. Seems the pre-redesign one didn't exactly have the best performance either. So, we should think in this regard and then work our way through.
As of the performance decrement in this comparison, my best guess would be increased DOM length. But that doesn't justify for a huge decrement in performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #1148: feat: remove canvas & add schema
URL: https://github.com/apache/apisix-website/pull/1148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152827907
### <span aria-hidden="true">👷</span> Deploy Preview for *apache-apisix* processing.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 67b17eb4fb3c8ef2bbe8fae570b4168194310c3a |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/62a3ed8d8541870008b42470 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #1148: feat: remove canvas & add schema
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on PR #1148:
URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1152943236
Hi @1502shivam-singh @SkyeYoung, the reason to remove the Canvas depends on two reasons:
1. Visitors report that the two canvas sections don't have a special meaning. I don't have better ideas, so I removed them in this PR.
2. https://pagespeed.web.dev/ reports that the landing page performance is terrible. It takes a long time to interact. But @1502shivam-singh is correct, as the following screenshot shows, the current site performance is even better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org