You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/01/29 08:49:38 UTC

[jira] Created: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
--------------------------------------------------------------------------------

                 Key: PIG-1212
                 URL: https://issues.apache.org/jira/browse/PIG-1212
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.6.0
            Reporter: Daniel Dai
            Assignee: Daniel Dai
             Fix For: 0.7.0


The following script through a NPE:

a = load '1.txt' as (a0:chararray);
b = load '2.txt' as (b0:chararray);
c = join a by a0, b by b0;
d = filter c by a0 == 'a';
explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1212:
----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Patch committed. Thanks Richard!

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch, PIG-1212-2.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1212:
----------------------------

    Description: 
The following script throw a NPE:

a = load '1.txt' as (a0:chararray);
b = load '2.txt' as (b0:chararray);
c = join a by a0, b by b0;
d = filter c by a0 == 'a';
explain d;

  was:
The following script through a NPE:

a = load '1.txt' as (a0:chararray);
b = load '2.txt' as (b0:chararray);
c = join a by a0, b by b0;
d = filter c by a0 == 'a';
explain d;


> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai closed PIG-1212.
---------------------------


> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch, PIG-1212-2.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806463#action_12806463 ] 

Richard Ding commented on PIG-1212:
-----------------------------------

Looks good. The only comment I have is about coding convention: "if statements always use braces {}."  Otherwise +1.

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806329#action_12806329 ] 

Hadoop QA commented on PIG-1212:
--------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12431758/PIG-1212-1.patch
  against trunk revision 904241.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/192/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/192/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/192/console

This message is automatically generated.

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1212:
----------------------------

    Attachment: PIG-1212-1.patch

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1212:
----------------------------

    Status: Patch Available  (was: Open)

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-1212) LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1212:
----------------------------

    Attachment: PIG-1212-2.patch

Address Richard's comment.

> LogicalPlan.replaceAndAddSucessors produce wrong result when successors are null
> --------------------------------------------------------------------------------
>
>                 Key: PIG-1212
>                 URL: https://issues.apache.org/jira/browse/PIG-1212
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.6.0
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.7.0
>
>         Attachments: PIG-1212-1.patch, PIG-1212-2.patch
>
>
> The following script throw a NPE:
> a = load '1.txt' as (a0:chararray);
> b = load '2.txt' as (b0:chararray);
> c = join a by a0, b by b0;
> d = filter c by a0 == 'a';
> explain d;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.