You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/01 12:32:35 UTC

[GitHub] [hudi] todd5167 opened a new pull request #5202: flink supports sync table information to aws glue

todd5167 opened a new pull request #5202:
URL: https://github.com/apache/hudi/pull/5202


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086546289


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732",
       "triggerID" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a5079b3dcbb32dd230cde983583df95445350d26 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085933756


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085939487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086090430


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085845169


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086498930


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732",
       "triggerID" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   * a5079b3dcbb32dd230cde983583df95445350d26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085848966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085939487


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086498930


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732",
       "triggerID" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   * a5079b3dcbb32dd230cde983583df95445350d26 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7732) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] danny0405 commented on a change in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r840994469



##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveSyncMode.java
##########
@@ -26,6 +26,10 @@
    * The HMS mode use the hive meta client to sync metadata.
    */
   HMS,
+  /**
+   * The GLUE mode use the glue client to sync metadata.
+   */
+  GLUE,

Review comment:
       Not sure if `GLUE` belongs to kind of sync mode ? Even though GLUE uses supports hive protocol, we may need to think how to re-organize these syncing params.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] garyli1019 commented on a change in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r840571581



##########
File path: hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java
##########
@@ -48,7 +51,15 @@ private HiveSyncContext(HiveSyncConfig syncConfig, HiveConf hiveConf, FileSystem
   }
 
   public HiveSyncTool hiveSyncTool() {
-    return new HiveSyncTool(this.syncConfig, this.hiveConf, this.fs);
+    HiveSyncMode syncMode = HiveSyncMode.of(syncConfig.syncMode);
+    switch (syncMode) {
+      case HMS:

Review comment:
       the default sync mode in FlinkOptions is JDBC actually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085933756


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086483304


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086483304


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] garyli1019 commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
garyli1019 commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086481562


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] garyli1019 merged pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
garyli1019 merged pull request #5202:
URL: https://github.com/apache/hudi/pull/5202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086496823


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   * a5079b3dcbb32dd230cde983583df95445350d26 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086496823


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728",
       "triggerID" : "1086481562",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a5079b3dcbb32dd230cde983583df95445350d26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7728) 
   * a5079b3dcbb32dd230cde983583df95445350d26 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] todd5167 commented on a change in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
todd5167 commented on a change in pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r840994988



##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveSyncMode.java
##########
@@ -26,6 +26,10 @@
    * The HMS mode use the hive meta client to sync metadata.
    */
   HMS,
+  /**
+   * The GLUE mode use the glue client to sync metadata.
+   */
+  GLUE,

Review comment:
       > Not sure if `GLUE` belongs to kind of sync mode ? Even though GLUE uses supports hive protocol, we may need to think how to re-organize these syncing params.
   
   
   The glue client depends on hiveconf, and the parameters currently used in my test are configured as follows:
   
     'hive_sync.enable' = 'true',
     'hive_sync.mode' = 'glue',
     'hive_sync.table' = 'test_hudi_glue',
     'hive_sync.skip_ro_suffix' = 'true',
     'hive_sync.db' = 'hudi_meta_glue'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085848966


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1085845169


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 53b24dd99aecf8b85f41e6f47865ca3e132b0e73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#issuecomment-1086090430


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7696",
       "triggerID" : "53b24dd99aecf8b85f41e6f47865ca3e132b0e73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704",
       "triggerID" : "8308601fc29e31f6c060e1a38ebd06d6b429b1ae",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8308601fc29e31f6c060e1a38ebd06d6b429b1ae Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7704) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org