You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/14 04:34:43 UTC
[GitHub] [spark] gengliangwang opened a new pull request #32158: [DO NOT MERGE] Try the new Github action process
gengliangwang opened a new pull request #32158:
URL: https://github.com/apache/spark/pull/32158
Let's verify the new process from https://github.com/apache/spark/pull/32092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819281132
Got it, thanks @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-822938235
It should be fine now. Let me close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819753259
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819306040
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821089001
**[Test build #755330484](https://github.com/gengliangwang/spark/actions/runs/755330484)** for PR 32158 at commit [`fc61869`](https://github.com/gengliangwang/spark/commit/fc61869ad7fda1fd62b48067539f3c5d84d05e00).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819267854
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821117624
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42058/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819698606
**[Test build #137367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137367/testReport)** for PR 32158 at commit [`8a79b5e`](https://github.com/apache/spark/commit/8a79b5eaabcba69e24d21f906c008b04477aa62b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819305051
**[Test build #137323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137323/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819753213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819307197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819698606
**[Test build #137367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137367/testReport)** for PR 32158 at commit [`8a79b5e`](https://github.com/apache/spark/commit/8a79b5eaabcba69e24d21f906c008b04477aa62b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819307170
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819267854
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32158:
URL: https://github.com/apache/spark/pull/32158#discussion_r612956545
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -64,7 +64,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val queryCoalesce = sql("select coalesce(null, 1, '1') from src ")
checkAnswer(queryCaseWhen, Row("1.0") :: Nil)
- checkAnswer(queryCoalesce, Row("1") :: Nil)
+ checkAnswer(queryCoalesce, Row("2") :: Nil)
Review comment:
In worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821117388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819454049
**[Test build #747046279](https://github.com/gengliangwang/spark/actions/runs/747046279)** for PR 32158 at commit [`9536df2`](https://github.com/gengliangwang/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819405058
**[Test build #137329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137329/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819275726
I can't see the comment from `github-actions` as it did in https://github.com/HyukjinKwon/spark/pull/34. Is it supposed to comment after testing finished or only in certain cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819258253
> BTW, just a question, for the failed GA, only the owner can re-trigger it because it's running on his repo, @HyukjinKwon and @gengliangwang ?
> In the worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though
That's true.
How about having a backdoor that triggers the test in Apache/Spark upon certain comments? Similar to what we did for Jenkins: "ok to test"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819251697
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819790498
**[Test build #137367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137367/testReport)** for PR 32158 at commit [`8a79b5e`](https://github.com/apache/spark/commit/8a79b5eaabcba69e24d21f906c008b04477aa62b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819307197
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819280402
The comment will be added by "Notify test workflow" job later. There are too many jobs in the queue so it's not triggered yet ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32158:
URL: https://github.com/apache/spark/pull/32158#discussion_r612956545
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -64,7 +64,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val queryCoalesce = sql("select coalesce(null, 1, '1') from src ")
checkAnswer(queryCaseWhen, Row("1.0") :: Nil)
- checkAnswer(queryCoalesce, Row("1") :: Nil)
+ checkAnswer(queryCoalesce, Row("2") :: Nil)
Review comment:
In the worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819303856
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821149513
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819417509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819268385
**[Test build #137329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137329/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819247974
Thank you, @gengliangwang . :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32158:
URL: https://github.com/apache/spark/pull/32158#discussion_r612956141
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -64,7 +64,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val queryCoalesce = sql("select coalesce(null, 1, '1') from src ")
checkAnswer(queryCaseWhen, Row("1.0") :: Nil)
- checkAnswer(queryCoalesce, Row("1") :: Nil)
+ checkAnswer(queryCoalesce, Row("2") :: Nil)
Review comment:
```suggestion
```
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -64,7 +64,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
val queryCoalesce = sql("select coalesce(null, 1, '1') from src ")
checkAnswer(queryCaseWhen, Row("1.0") :: Nil)
- checkAnswer(queryCoalesce, Row("1") :: Nil)
+ checkAnswer(queryCoalesce, Row("2") :: Nil)
Review comment:
```suggestion
checkAnswer(queryCoalesce, Row("2") :: Nil)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821117624
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42058/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819827935
**[Test build #749195392](https://github.com/gengliangwang/spark/actions/runs/749195392)** for PR 32158 at commit [`8a79b5e`](https://github.com/gengliangwang/spark/commit/8a79b5eaabcba69e24d21f906c008b04477aa62b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819753259
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819238277
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41903/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819221930
**[Test build #137323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137323/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819248664
BTW, just a question, for the failed GA, only the owner can re-trigger it because it's running on his repo, @HyukjinKwon and @gengliangwang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819825403
**[Test build #749195392](https://github.com/gengliangwang/spark/actions/runs/749195392)** for PR 32158 at commit [`edf2178`](https://github.com/gengliangwang/spark/commit/edf21781d20d7f6f231faec8c3700468dc89d35a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821149513
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137483/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819791007
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137367/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819261643
I'm not sure if that's feasible or not but that would be great to have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821149073
**[Test build #137483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137483/testReport)** for PR 32158 at commit [`fc61869`](https://github.com/apache/spark/commit/fc61869ad7fda1fd62b48067539f3c5d84d05e00).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819258253
> BTW, just a question, for the failed GA, only the owner can re-trigger it because it's running on his repo, @HyukjinKwon and @gengliangwang ?
> In the worst case (e.g., author is inactive but PR is ready .. ?), we could push an empty commit to their branch to retrigger .. of course this is an ugly way though
That's true.
How about having a backdoor that triggers the test in Apache/Spark upon certain comments? Similar to what we did for Jenkins: "ok to test"/"retest this please"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #32158:
URL: https://github.com/apache/spark/pull/32158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819221930
**[Test build #137323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137323/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821089703
**[Test build #137483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137483/testReport)** for PR 32158 at commit [`fc61869`](https://github.com/apache/spark/commit/fc61869ad7fda1fd62b48067539f3c5d84d05e00).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819417509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137329/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-821089703
**[Test build #137483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137483/testReport)** for PR 32158 at commit [`fc61869`](https://github.com/apache/spark/commit/fc61869ad7fda1fd62b48067539f3c5d84d05e00).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-822652869
Do we need to test this more, @gengliangwang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819306040
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819268385
**[Test build #137329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137329/testReport)** for PR 32158 at commit [`9536df2`](https://github.com/apache/spark/commit/9536df22cc34b5732e9133e9ab1fd6316c06ad83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819221556
GA starts: https://github.com/gengliangwang/spark/actions/runs/747046279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819249043
Ah.. good point. Yeah ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32158: [DO NOT MERGE] Try the new Github action process
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32158:
URL: https://github.com/apache/spark/pull/32158#issuecomment-819791007
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137367/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org