You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2011/08/18 21:05:29 UTC
[jira] [Created] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
NoSuchColumnFamilyException in multi doesn't say which family is bad
--------------------------------------------------------------------
Key: HBASE-4225
URL: https://issues.apache.org/jira/browse/HBASE-4225
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Priority: Critical
Fix For: 0.90.5
It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
{code}
LOG.warn("No such column family in batch put", nscf);
batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
{code}
So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
{code}
} else if (code == OperationStatusCode.BAD_FAMILY) {
result = new NoSuchColumnFamilyException();
{code}
We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089748#comment-13089748 ]
Jean-Daniel Cryans commented on HBASE-4225:
-------------------------------------------
+1 on patch, thanks for taking care of this Ram!
In the future I'd like to see a description with the patch to explain the changes, leave it in the comment when attaching the file. This way the reviewer is more effective. In this case something simple like this would have been enough:
bq. Created a new class OperationStatus that wraps OperationStatusCode and an exception message, most of the patch consists of the former replacing the latter.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089567#comment-13089567 ]
Ted Yu commented on HBASE-4225:
-------------------------------
Please use tool such as dos2unix to remove extra new lines.
{code}
+^M
+public class OperationStatus {^
{code}
Please add javadoc for the new class explaining its purpose. It allows adding more details for operation status in the future.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4225:
----------------------------------
Fix Version/s: 0.92.0
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.92.0, 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Open (was: Patch Available)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Patch Available (was: Open)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Open (was: Patch Available)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Attachment: HBASE-4225_0.90_3.patch
Thanks for the comments.
Removed the ^M and added javadoc.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089759#comment-13089759 ]
stack commented on HBASE-4225:
------------------------------
+1
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Patch Available (was: Open)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Patch Available (was: Open)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Attachment: HBASE-4225_0.90_2.patch
As discussed add the new Class OperationStatus
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089778#comment-13089778 ]
stack commented on HBASE-4225:
------------------------------
oh... my fault. J-D pointed out patch was for 0.90. It applies there. I added it. Can we have a version for TRUNK?
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4225:
--------------------------
Attachment: 4225.trunk
Patch for TRUNK.
TestHRegion passed.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089916#comment-13089916 ]
Hudson commented on HBASE-4225:
-------------------------------
Integrated in HBase-TRUNK #2134 (See [https://builds.apache.org/job/HBase-TRUNK/2134/])
HBASE-4225 OperationStatus.java was missing in previous checkin
HBASE-4225 NoSuchColumnFamilyException in multi doesn't say which family
is bad (Ramkrishna Vasudevan)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Attachment: HBASE-4225_0.90.patch
Submitting the patch for 0.90.x version as given in the defect description.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089826#comment-13089826 ]
Ted Yu commented on HBASE-4225:
-------------------------------
Integrated to TRUNK.
Thanks for the patch Ramkrishna.
Thanks for the review Michael and J-D.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088804#comment-13088804 ]
Ted Yu commented on HBASE-4225:
-------------------------------
For put(Pair<Put, Integer>[] putsAndLocks):
{code}
+ * @return Returns a Pair object containing the operation status code along with the exception
{code}
The return value is actually an array of Pairs.
Good work.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090018#comment-13090018 ]
ramkrishna.s.vasudevan commented on HBASE-4225:
-----------------------------------------------
Thanks Ted, JD and Stack.
@JD
I will do follow what you said. Thanks once again.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4225:
--------------------------
Resolution: Fixed
Release Note: Created a new class OperationStatus that wraps OperationStatusCode and an exception message, most of the patch consists of the former replacing the latter.
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: 4225.trunk, HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4225:
--------------------------
Status: Patch Available (was: Open)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089597#comment-13089597 ]
Ted Yu commented on HBASE-4225:
-------------------------------
+1 on 90 patch version 3.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089581#comment-13089581 ]
Ted Yu commented on HBASE-4225:
-------------------------------
{code}
+ * This class is added with a purpose of adding more details or info regarding
{code}
I would write the above this way (80 characters wide):
{code}
+ * This class is created for the purpose of adding more details or info regarding
{code}
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan reassigned HBASE-4225:
---------------------------------------------
Assignee: ramkrishna.s.vasudevan
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089765#comment-13089765 ]
stack commented on HBASE-4225:
------------------------------
Let me commit.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Status: Open (was: Patch Available)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4225) NoSuchColumnFamilyException in
multi doesn't say which family is bad
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089770#comment-13089770 ]
stack commented on HBASE-4225:
------------------------------
I tried to commit but patch would not apply. I tried hacking it in but ran into more issues.....Your trunk is behind I think Ram. Any chance of a patch against a trunk refresh? Thank you.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch, HBASE-4225_0.90_2.patch, HBASE-4225_0.90_3.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4225) NoSuchColumnFamilyException in multi
doesn't say which family is bad
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-4225:
------------------------------------------
Attachment: HBASE-4225_0.90_1.patch
@Ted,
Changed the javadoc as per the comment.:)
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira