[jira] [Commented] (FLINK-19656) Automatically replace delimiter in metric name components

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-19656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245812#comment-17245812 ] 

Chesnay Schepler commented on FLINK-19656:
------------------------------------------

[~echauchot] Not quite. What you missed is that the delimiter is configurable, and this is not visible to the reporter. The configured delimiter is injected by the {{FrontMetricGroup}}. We also have to adjust {{AbstractMetricGroup#getAllVariables()}} to accept a filter.

> Automatically replace delimiter in metric name components
> ---------------------------------------------------------
>
>                 Key: FLINK-19656
>                 URL: https://issues.apache.org/jira/browse/FLINK-19656
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>            Reporter: Chesnay Schepler
>            Priority: Major
>              Labels: starter
>             Fix For: 1.13.0
>
>
> The metric name consists of various components (like job ID, task ID), that are then joined by a delimiter(commonly {{.}}).
> The delimiter isn't just for convention, but also carries semantics for many metric backends, as they organize metrics based on the delimiter.
> This can behave in unfortunate ways if the delimiter is contained with a given component, as it will now be split up by the backend.
> We should automatically filter such occurrences to prevent this from happening.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)