You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sam Overton (Created) (JIRA)" <ji...@apache.org> on 2012/04/05 16:15:24 UTC

[jira] [Created] (CASSANDRA-4125) Update nodetool for vnodes

Update nodetool for vnodes
--------------------------

                 Key: CASSANDRA-4125
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
             Project: Cassandra
          Issue Type: Sub-task
            Reporter: Sam Overton
            Assignee: Sam Overton


The proposed changes are intended to preserve backwards compatibility:

|| op || behaviour || deprecated warning?
| join | Join the ring, use with <tt>-t</tt> to join at a specific token, or to add a token to an existing host |
| ring | prints the first token for each node, add <tt>-a</tt> to print all tokens |
| move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
| removetoken status/force/<token> | removes the node who owns <token> from the ring. use <tt>-t</tt> option to only remove the token from the node instead of the whole node. |
| describering [keyspace] | show all ranges and their endpoints |
| getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416729#comment-13416729 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

OK, this output is implemented in: https://github.com/acunu/cassandra/commit/30710fb

As of yet, I haven't figured out the strange ownership values (other than it being more fallout from CASSANDRA-3047).
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410919#comment-13410919 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

{{clusterinfo}} ownership fixed in https://github.com/acunu/cassandra/commit/bc9cae9
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409817#comment-13409817 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

Can we also remove the deprecated methods here?
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411830#comment-13411830 ] 

Brandon Williams edited comment on CASSANDRA-4125 at 7/11/12 6:36 PM:
----------------------------------------------------------------------

I think we may still have a problem with ownership calculation:

{{noformat}}

Address          Status  State    Load       Tokens  Owns (effective) Host ID
10.179.65.102    Up      Normal   197.82 MB  1       66.67%           e1c24ebd-e9c0-40eb-9419-e510d849c3e0
10.179.111.137   Up      Normal   197.95 MB  256     99.87%           c9a17642-35dd-4eb5-9881-9631a5590a40
10.179.64.227    Up      Normal   197.6 MB   1       33.46%           574f6677-d7a5-405a-9fb8-5c4d829f0a10
{{noformat}}

.137 has 256 tokens, but they should be contiguous (upgraded)
                
      was (Author: brandon.williams):
    I think we may still have a problem with ownership calculation:

{{noformat}}

Address          Status  State    Load       Tokens  Owns (effective) Host ID
10.179.65.102    Up      Normal   197.82 MB  1       66.67%           e1c24ebd-e9c0-40eb-9419-e510d849c3e0
10.179.111.137   Up      Normal   197.95 MB  256     99.87%           c9a17642-35dd-4eb5-9881-9631a5590a40
10.179.64.227    Up      Normal   197.6 MB   1       33.46%           574f6677-d7a5-405a-9fb8-5c4d829f0a10
{{noformat}

.137 has 256 tokens, but they should be contiguous (upgraded)
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415616#comment-13415616 ] 

Eric Evans edited comment on CASSANDRA-4125 at 7/16/12 9:07 PM:
----------------------------------------------------------------

Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ==  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ==  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ==  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                
      was (Author: urandom):
    Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410959#comment-13410959 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

bq. What if we removed "Load" from clusterinfo to free up a little real estate (that seems like something people could get form info),

I don't think people will be very happy if we take that away, they're pretty used to being able to see that for all the machines in one shot.

bq. added a "rack" column, and then page the list by DC the way CASSANDRA-3047 aimed to?

I do like paging by DC, that least saves some horizontal real estate by using vertical instead.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409921#comment-13409921 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

bq. Can we also remove the deprecated methods here?

Done in https://github.com/acunu/cassandra/commit/4486bdd
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-4125:
----------------------------------

    Fix Version/s: 1.2
    
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>             Fix For: 1.2
>
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417280#comment-13417280 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

The ownership calculation should be fixed now.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415641#comment-13415641 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

lgtm.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415616#comment-13415616 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  256     11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      256     11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    256     11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  256     11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      256     11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    256     11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  256     11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      256     11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    256     11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411830#comment-13411830 ] 

Brandon Williams edited comment on CASSANDRA-4125 at 7/11/12 6:37 PM:
----------------------------------------------------------------------

I think we may still have a problem with ownership calculation:

{noformat}
Address          Status  State    Load       Tokens  Owns (effective) Host ID
10.179.65.102    Up      Normal   197.82 MB  1       66.67%           e1c24ebd-e9c0-40eb-9419-e510d849c3e0
10.179.111.137   Up      Normal   197.95 MB  256     99.87%           c9a17642-35dd-4eb5-9881-9631a5590a40
10.179.64.227    Up      Normal   197.6 MB   1       33.46%           574f6677-d7a5-405a-9fb8-5c4d829f0a10
{noformat}

.137 has 256 tokens, but they should be contiguous (upgraded)
                
      was (Author: brandon.williams):
    I think we may still have a problem with ownership calculation:

{{noformat}}

Address          Status  State    Load       Tokens  Owns (effective) Host ID
10.179.65.102    Up      Normal   197.82 MB  1       66.67%           e1c24ebd-e9c0-40eb-9419-e510d849c3e0
10.179.111.137   Up      Normal   197.95 MB  256     99.87%           c9a17642-35dd-4eb5-9881-9631a5590a40
10.179.64.227    Up      Normal   197.6 MB   1       33.46%           574f6677-d7a5-405a-9fb8-5c4d829f0a10
{{noformat}}

.137 has 256 tokens, but they should be contiguous (upgraded)
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans resolved CASSANDRA-4125.
-----------------------------------

    Resolution: Fixed

committed to trunk; thanks everyone!
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>             Fix For: 1.2
>
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415565#comment-13415565 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

I like this, though maybe we could omit printing the status/state key all the time and put that in the help instead.  It'd be nice to also print the first token, that way legacy machines with just one token achieve the 'one stop shop' goal.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-4125:
----------------------------------

    Description: 
The proposed changes are intended to preserve backwards compatibility:

|| op || behaviour || deprecated warning?
| join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
| ring | prints the first token for each node, add {{-a}} to print all tokens |
| move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
| removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
| describering [keyspace] | show all ranges and their endpoints |
| getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

_Edit0: Appended patch information._

h3. Patches
||Compare||Raw diff||Description||
|[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|

----

_Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._


  was:
The proposed changes are intended to preserve backwards compatibility:

|| op || behaviour || deprecated warning?
| join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
| ring | prints the first token for each node, add {{-a}} to print all tokens |
| move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
| removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
| describering [keyspace] | show all ranges and their endpoints |
| getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

    
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417287#comment-13417287 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

+1
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410899#comment-13410899 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

bq. Did it support a -a argument at some point?

I don't think so, but it's in the description and might be a good idea, since people used to pre-vnode cassandra might be a bit shocked when thousands of lines scroll by when running it :)

bq. I'm of the opinion that it doesn't make sense to visualize the ring anymore. Perhaps it would be enough to incorporate some sort of per-DC ownership display into clusterinfo.

I was thinking more of upgrades that aren't on vnodes yet.  If you want to move a node, you need ring to get the token.  If you want to remove a node, you need clusterinfo to get the hostid.  And then if you want to know dc/rack info, you're back to ring (even with vnodes, except now you get scrollshocked.)  It just seems like it'd be nice to get all the info you need from one place, the way ring currently works.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Sam Overton (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Overton updated CASSANDRA-4125:
-----------------------------------

    Description: 
The proposed changes are intended to preserve backwards compatibility:

|| op || behaviour || deprecated warning?
| join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
| ring | prints the first token for each node, add {{-a}} to print all tokens |
| move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
| removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
| describering [keyspace] | show all ranges and their endpoints |
| getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

  was:
The proposed changes are intended to preserve backwards compatibility:

|| op || behaviour || deprecated warning?
| join | Join the ring, use with <tt>-t</tt> to join at a specific token, or to add a token to an existing host |
| ring | prints the first token for each node, add <tt>-a</tt> to print all tokens |
| move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
| removetoken status/force/<token> | removes the node who owns <token> from the ring. use <tt>-t</tt> option to only remove the token from the node instead of the whole node. |
| describering [keyspace] | show all ranges and their endpoints |
| getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

    
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Sam Overton
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410882#comment-13410882 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

bq. Ring still appears to print all the tokens without -a, not just the first, but otherwise looks good.

Did it support a {{-a}} argument at some point?

{quote}
Also the 'owns' column in clusterinfo seems to have been broken (but I know it used to work) as it always reports zero now.
{quote}

Right, probably more fall out from merging CASSANDRA-3047; Will have a look.

{quote}
...perhaps we should think about combining ring and clusterinfo together, since depending on your setup and what you're doing you may have to go back and forth to get what you need.
{quote}

I'm of the opinion that it doesn't make sense to visualize the ring anymore.  Perhaps it would be enough to incorporate some sort of per-DC ownership display into clusterinfo.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411830#comment-13411830 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

I think we may still have a problem with ownership calculation:

{{noformat}}

Address          Status  State    Load       Tokens  Owns (effective) Host ID
10.179.65.102    Up      Normal   197.82 MB  1       66.67%           e1c24ebd-e9c0-40eb-9419-e510d849c3e0
10.179.111.137   Up      Normal   197.95 MB  256     99.87%           c9a17642-35dd-4eb5-9881-9631a5590a40
10.179.64.227    Up      Normal   197.6 MB   1       33.46%           574f6677-d7a5-405a-9fb8-5c4d829f0a10
{{noformat}

.137 has 256 tokens, but they should be contiguous (upgraded)
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415616#comment-13415616 ] 

Eric Evans edited comment on CASSANDRA-4125 at 7/16/12 8:44 PM:
----------------------------------------------------------------

Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                
      was (Author: urandom):
    Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413151#comment-13413151 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

bq. I think new users want to be able to see how much space their cluster is using at a glance, and foresee a lot of complaints if we remove it at this point. Also, it's easier to say "send me your ring output" than "send me the ring output, then the output of info from each node" and space used is still pertinent information to have, outside of balance issues.

I think we're on the same page wrt that point, all-on-one vs. spread-over-two, (s/ring output/clusterinfo output/ though).  I just wanted to test the assertion that all of that information is still necessary.

I'm sure it can be made compact enough to display everything.


                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415616#comment-13415616 ] 

Eric Evans edited comment on CASSANDRA-4125 at 7/16/12 8:42 PM:
----------------------------------------------------------------

Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                
      was (Author: urandom):
    Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  256     11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      256     11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    256     11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  256     11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      256     11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    256     11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Tokens  Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  256     11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      256     11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    256     11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410597#comment-13410597 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

Ring still appears to print all the tokens without -a, not just the first, but otherwise looks good.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411493#comment-13411493 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

bq. Is this because it's one aspect of monitoring / maintaining balance between the nodes?

More as a quick check since, even with vnodes, you can create a large imbalance via fat rows.  

bq. Do you think this will be less relevant now?

To some degree, but not completely.

I think new users want to be able to see how much space their cluster is using at a glance, and foresee a lot of complaints if we remove it at this point.  Also, it's easier to say "send me your ring output" than "send me the ring output, then the output of info from each node" and space used is still pertinent information to have, outside of balance issues.

                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410629#comment-13410629 ] 

Brandon Williams edited comment on CASSANDRA-4125 at 7/10/12 6:13 PM:
----------------------------------------------------------------------

Also the 'owns' column in clusterinfo seems to have been broken (but I know it used to work) as it always reports zero now.  On that note, perhaps we should think about combining ring and clusterinfo together, since depending on your setup and what you're doing you may have to go back and forth to get what you need.
                
      was (Author: brandon.williams):
    Also the 'owns' column in clusterinfo seems to have been broken (but I know it used to work) as it always reports zero now.  On that note, perhaps we should think about combining ring and clusterinfo together, since depending on your setup and what you're doing you maybe have to go back and forth to get what you need.
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415616#comment-13415616 ] 

Eric Evans edited comment on CASSANDRA-4125 at 7/16/12 8:49 PM:
----------------------------------------------------------------

Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                
      was (Author: urandom):
    Adding a token column that is conditionally printed when num_tokens == 1

{noformat}
 Datacenter: Greece
 ==================
 Status=Up/Down
 |/ State=Normal/Leaving/Joining/Moving
 ++  Address          Load      Owns   Host ID                               Token                                  Rack
 UN  222.222.222.221  999.9 KB  11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  0                                      rack1
 UL  222.222.222.222  1 MB      11.1%  528d3b78-305d-4319-bedd-393927fedb48  886151997189943915269204706853563050   rack2
 UN  222.222.222.222  999 MB    11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  1772303994379887830538409413707126100  rack3
 
 Datacenter: CostaRica
 =====================
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.223.222.221  999.9 KB  11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  9747671969089383067961251775389193550   rack11
 UL  222.223.222.222  1 MB      11.1%  b28d3b78-305d-4319-bedd-393927fedb48  10633823966279326983230456482242756600  rack22
 UN  222.223.222.222  999 MB    11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  11519975963469270898499661189096319650  rack33
 
 Datacenter: BritishColumbia
 ===========================
 ++  Address          Load      Owns   Host ID                               Token                                   Rack
 UN  222.224.222.221  999.9 KB  11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  12406127960659214813768865895949882700  rack12
 UL  222.224.222.222  1 MB      11.1%  e28d3b78-305d-4319-bedd-393927fedb48  13292279957849158729038070602803445750  rack22
 UN  222.224.222.222  999 MB    11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  14178431955039102644307275309657008800  rack33
{noformat}

Not a huge fan of this myself.
                  
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410985#comment-13410985 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

bq. I don't think people will be very happy if we take [the Load column] away, they're pretty used to being able to see that for all the machines in one shot.

Is this because it's one aspect of monitoring / maintaining balance between the nodes?  Do you think this will be less relevant now?
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4125:
--------------------------------------

    Reviewer: brandon.williams
    
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415556#comment-13415556 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

How about something like this?

{noformat}
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
++  Address          Load      Tokens  Owns   Host ID                               Rack
UN  222.222.222.221  999.9 KB  256     33.3%  2ed2bb57-5541-478e-be55-cf4a800fca87  rack1
UL  222.222.222.222  1 MB      256     33.3%  528d3b78-305d-4319-bedd-393927fedb48  rack2
UN  222.222.222.222  999 MB    256     33.3%  78843aba-6131-4d00-b38c-306086c5dcc7  rack3
{noformat}

With more than one datacenter:

{noformat}
Datacenter: Greece
==================
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
++  Address          Load      Tokens  Owns   Host ID                               Rack
UN  222.222.222.221  999.9 KB  256     11.1%  2ed2bb57-5541-478e-be55-cf4a800fca87  rack1
UL  222.222.222.222  1 MB      256     11.1%  528d3b78-305d-4319-bedd-393927fedb48  rack2
UN  222.222.222.222  999 MB    256     11.1%  78843aba-6131-4d00-b38c-306086c5dcc7  rack3
 
Datacenter: CostaRica
=====================
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
++  Address          Load      Tokens  Owns   Host ID                               Rack
UN  222.223.222.221  999.9 KB  256     11.1%  aed2bb57-5541-478e-be55-cf4a800fca87  rack11
UL  222.223.222.222  1 MB      256     11.1%  b28d3b78-305d-4319-bedd-393927fedb48  rack22
UN  222.223.222.222  999 MB    256     11.1%  c8843aba-6131-4d00-b38c-306086c5dcc7  rack33
 
Datacenter: BritishColumbia
===========================
Status=Up/Down
|/ State=Normal/Leaving/Joining/Moving
++  Address          Load      Tokens  Owns   Host ID                               Rack
UN  222.224.222.221  999.9 KB  256     11.1%  ded2bb57-5541-478e-be55-cf4a800fca87  rack12
UL  222.224.222.222  1 MB      256     11.1%  e28d3b78-305d-4319-bedd-393927fedb48  rack22
UN  222.224.222.222  999 MB    256     11.1%  f8843aba-6131-4d00-b38c-306086c5dcc7  rack33
{noformat}
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-4125:
----------------------------------

    Assignee: Eric Evans  (was: Sam Overton)
    
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410953#comment-13410953 ] 

Eric Evans commented on CASSANDRA-4125:
---------------------------------------

{quote}
[the -a arg is] in the description and might be a good idea, since people used to pre-vnode cassandra might be a bit shocked when thousands of lines scroll by when running it :)
{quote}

We could deprecate it, run it with a deprecation warning if num_tokens == 1, and force an additional argument to be passed (--yes-I-want-to-be-scroll-shocked) when num_tokens > 1.

The problem I have with showing only one token is that it's very misleading.  The "ring" has always been used to visualize topology in a world where there was a 1:1 relationship between node and token.  Displaying our classic ring view with that 1:1 mapping when there are say hundreds of tokens seems almost certain to cause confusion.

{quote}
If you want to move a node, you need ring to get the token. If you want to remove a node, you need clusterinfo to get the hostid. And then if you want to know dc/rack info, you're back to ring (even with vnodes, except now you get scrollshocked.) It just seems like it'd be nice to get all the info you need from one place, the way ring currently works.
{quote}

What if we removed "Load" from {{clusterinfo}} to free up a little real estate (that seems like something people could get form {{info}}), added a "rack" column, and then page the list by DC the way CASSANDRA-3047 aimed to?

{noformat}
Datacenter: DC1
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Address          Rack   Status  State    Tokens  Owns    Host ID
127.0.1.3        rack1  Up      Normal   8       16.00%   aaaa59d9-e5f9-445e-bb4b-a29a55075698
127.0.2.2        rack2  Up      Normal   8       16.00%   bbbb31c5-e7eb-43c5-8393-2b71cd90d361
127.0.3.1        rack3  Up      Normal   8       16.00%   cccc0bee-7292-4adb-9eb5-1f3bfd6d6d92

Datacenter: DC2
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Address          Rack   Status  State    Tokens  Owns    Host ID
127.1.1.3        rack1  Up      Normal   8       16.00%   dddd59d9-e5f9-445e-bb4b-a29a55075698
127.1.2.2        rack2  Up      Normal   8       16.00%   eeee31c5-e7eb-43c5-8393-2b71cd90d361
127.1.3.1        rack3  Up      Normal   8       16.00%   ffff0bee-7292-4adb-9eb5-1f3bfd6d6d92
{noformat}
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-4125) Update nodetool for vnodes

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410629#comment-13410629 ] 

Brandon Williams commented on CASSANDRA-4125:
---------------------------------------------

Also the 'owns' column in clusterinfo seems to have been broken (but I know it used to work) as it always reports zero now.  On that note, perhaps we should think about combining ring and clusterinfo together, since depending on your setup and what you're doing you maybe have to go back and forth to get what you need.
                
> Update nodetool for vnodes
> --------------------------
>
>                 Key: CASSANDRA-4125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Sam Overton
>            Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens |
> | move <new token> | if the node only has 1 token then move it. Otherwise die with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from the ring. use {{-t}} option to only remove the token from the node instead of the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch output manually, you will either need to filter the TopGit metadata files (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}), or remove them afterward ({{rm .topmsg .topdeps}})._

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira