You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kyle Weaver (Jira)" <ji...@apache.org> on 2021/03/23 17:30:00 UTC

[jira] [Created] (BEAM-12033) Validate numeric literals during expression conversion.

Kyle Weaver created BEAM-12033:
----------------------------------

             Summary: Validate numeric literals during expression conversion.
                 Key: BEAM-12033
                 URL: https://issues.apache.org/jira/browse/BEAM-12033
             Project: Beam
          Issue Type: Improvement
          Components: dsl-sql-zetasql
            Reporter: Kyle Weaver
            Assignee: Kyle Weaver


Numeric literals in ZetaSQL are subject to constraints: they must fall within certain hardcoded limits, and the scale also cannot exceed 9. Currently these constraints are enforced when preparing the expression in BeamZetaSqlCalcRel. However, to force BeamCalcRel to have the same behavior, we should check the constraints earlier, during expression conversion.

https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745



--
This message was sent by Atlassian Jira
(v8.3.4#803005)