[GitHub] [incubator-brpc] Tuvie commented on a change in pull request #1002: fix two bugs about rdma

[GitBox <gi...@apache.org>]

Tuvie commented on a change in pull request #1002:
URL: https://github.com/apache/incubator-brpc/pull/1002#discussion_r532154596



##########
File path: src/brpc/server.cpp
##########
@@ -1055,16 +1055,16 @@ int Server::StartInternal(const butil::ip_t& ip,
             return -1;
         }
         std::unique_ptr<rdma::RdmaCommunicationManager> rh;
+        butil::EndPoint internal_point = _listen_addr;
+        internal_point.port = _options.internal_port;
         if (_options.use_rdma) {
-            rh.reset(rdma::RdmaCommunicationManager::Listen(_listen_addr));
+            rh.reset(rdma::RdmaCommunicationManager::Listen(internal_point));

Review comment:
       这是之前的一个bug，会对_listen_addr重复监听。internal_point没有必要启用rdma。新代码我移除了这块。




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org