You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/17 06:42:47 UTC
[kudu-CR] www: miscellaneous mustache updates
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14473
to look at the new patch set (#2).
Change subject: www: miscellaneous mustache updates
......................................................................
www: miscellaneous mustache updates
1. Converted /dashboards and /threadz into mustache templates. In /threadz,
I tried to defer as much work as possible outside the lock, since it must
be taken in write mode to create a new thread. While I was there I added
"fancy tables" to /threadz; /dashboards remains visually unchanged.
2. In /tablets, changed the handling of tablet links. In doing so, all links
(except for the main template) are now in templates instead of in code.
Screenshots: https://imgur.com/a/AOTQuH4
Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225
---
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/tserver/tserver_path_handlers.h
M src/kudu/util/thread.cc
A www/dashboards.mustache
M www/kudu.js
M www/tablets.mustache
A www/threadz.mustache
7 files changed, 185 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/14473/2
--
To view, visit http://gerrit.cloudera.org:8080/14473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb97a9e3bbefb8ee607638af6e069959c5354225
Gerrit-Change-Number: 14473
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)