You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/03/27 14:41:57 UTC
Review Request: OOZIE-786 tomcat should stop if oozie does not start
correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4524/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
making the webapp listener to do a System.exit(1) if an error occurs while starting the services.
This addresses bug OOZIE-786.
https://issues.apache.org/jira/browse/OOZIE-786
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java 1305822
Diff: https://reviews.apache.org/r/4524/diff
Testing
-------
build/deployed oozie and tested running the oozie-run.sh command without a created DB, and verified the Tomcat process ends.
Thanks,
Alejandro
Re: Review Request: OOZIE-786 tomcat should stop if oozie does not start
correctly
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4524/#review6439
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java
<https://reviews.apache.org/r/4524/#comment14053>
Are any of these imports required?
- Virag
On 2012-03-27 12:41:57, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4524/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 12:41:57)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> making the webapp listener to do a System.exit(1) if an error occurs while starting the services.
>
>
> This addresses bug OOZIE-786.
> https://issues.apache.org/jira/browse/OOZIE-786
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java 1305822
>
> Diff: https://reviews.apache.org/r/4524/diff
>
>
> Testing
> -------
>
> build/deployed oozie and tested running the oozie-run.sh command without a created DB, and verified the Tomcat process ends.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-786 tomcat should stop if oozie does not start
correctly
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4524/#review6444
-----------------------------------------------------------
Ship it!
- Virag
On 2012-03-27 19:33:00, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4524/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 19:33:00)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> making the webapp listener to do a System.exit(1) if an error occurs while starting the services.
>
>
> This addresses bug OOZIE-786.
> https://issues.apache.org/jira/browse/OOZIE-786
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java 1305822
>
> Diff: https://reviews.apache.org/r/4524/diff
>
>
> Testing
> -------
>
> build/deployed oozie and tested running the oozie-run.sh command without a created DB, and verified the Tomcat process ends.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-786 tomcat should stop if oozie does not start
correctly
Posted by Mayank Bansal <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4524/#review6446
-----------------------------------------------------------
Ship it!
+1
- Mayank
On 2012-03-27 19:33:00, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4524/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 19:33:00)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> making the webapp listener to do a System.exit(1) if an error occurs while starting the services.
>
>
> This addresses bug OOZIE-786.
> https://issues.apache.org/jira/browse/OOZIE-786
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java 1305822
>
> Diff: https://reviews.apache.org/r/4524/diff
>
>
> Testing
> -------
>
> build/deployed oozie and tested running the oozie-run.sh command without a created DB, and verified the Tomcat process ends.
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-786 tomcat should stop if oozie does not start
correctly
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4524/
-----------------------------------------------------------
(Updated 2012-03-27 19:33:00.979060)
Review request for oozie.
Changes
-------
removing spurious imports
Summary
-------
making the webapp listener to do a System.exit(1) if an error occurs while starting the services.
This addresses bug OOZIE-786.
https://issues.apache.org/jira/browse/OOZIE-786
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java 1305822
Diff: https://reviews.apache.org/r/4524/diff
Testing
-------
build/deployed oozie and tested running the oozie-run.sh command without a created DB, and verified the Tomcat process ends.
Thanks,
Alejandro