You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/13 11:08:34 UTC
[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
bartekkuncer opened a new pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666
## Description ##
This change simply upgrades the version of oneDNN being used on v1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
anko-intel commented on a change in pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#discussion_r793615630
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -113,16 +113,28 @@ std::shared_ptr<mkldnn::convolution_forward::primitive_desc> GetConvFwdImpl(
[¶m, &data, &weights, &output, &attr](const mkldnn::convolution_forward::desc& desc) {
auto engine = CpuEngine::Get()->get_engine();
try {
- // MKL-DNN introduced padded formats since 0.15 which require more memory
- // compared to the actual size of the tensor. Currently, MKL-DNN operators
- // still reuse memory from memory planning, so here we need to select a
- // suboptimal kernel for computation that has the expected memory size requirements
+ // MKLDNN introduced padded formats since 0.15 which require more
Review comment:
please keep max line with equal 100 in autoformater
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-1023017225
@mxnet-bot run ci [unix-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-942309648
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-951773355
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-942187995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#discussion_r792453753
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -113,16 +113,28 @@ std::shared_ptr<mkldnn::convolution_forward::primitive_desc> GetConvFwdImpl(
[¶m, &data, &weights, &output, &attr](const mkldnn::convolution_forward::desc& desc) {
auto engine = CpuEngine::Get()->get_engine();
try {
- // MKL-DNN introduced padded formats since 0.15 which require more memory
- // compared to the actual size of the tensor. Currently, MKL-DNN operators
- // still reuse memory from memory planning, so here we need to select a
- // suboptimal kernel for computation that has the expected memory size requirements
+ // MKLDNN introduced padded formats since 0.15 which require more
+ // memory compared to the actual size of the tensor. Currently, MKLDNN
+ // operators still reuse memory from memory planning, so here we need
+ // to select a suboptimal kernel for computation that has the expected
+ // memory size requirements
auto conv_pd =
- std::make_shared<mkldnn::convolution_forward::primitive_desc>(desc, attr, engine);
- while (conv_pd->dst_desc().get_size() != GetArraySize(output) ||
- conv_pd->src_desc().get_size() != GetArraySize(data) ||
- (!param.mkldnn_param.quantized &&
- conv_pd->weights_desc().get_size() != GetArraySize(weights))) {
+ std::make_shared<mkldnn::convolution_forward::primitive_desc>(
+ desc, attr, engine);
+ while (
+ conv_pd->dst_desc().get_size() != GetArraySize(output) ||
+ conv_pd->src_desc().get_size() != GetArraySize(data) ||
+ (!param.mkldnn_param.quantized &&
+ conv_pd->weights_desc().get_size() != GetArraySize(weights)) ||
+ // With the upgrade of MKLDNN to version 2.4+
+ // tests/python/mkl/test_subgraph.py::test_pos_conv_add
+ // started failing. Switching away from primitive with weight
+ // mkldnn::format_tag ABcd4b16a4b is in place to temporairly fix
Review comment:
```suggestion
// mkldnn::format_tag ABcd4b16a4b in order to temporarily fix
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
bgawrych merged pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on a change in pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on a change in pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#discussion_r793635810
##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -113,16 +113,28 @@ std::shared_ptr<mkldnn::convolution_forward::primitive_desc> GetConvFwdImpl(
[¶m, &data, &weights, &output, &attr](const mkldnn::convolution_forward::desc& desc) {
auto engine = CpuEngine::Get()->get_engine();
try {
- // MKL-DNN introduced padded formats since 0.15 which require more memory
- // compared to the actual size of the tensor. Currently, MKL-DNN operators
- // still reuse memory from memory planning, so here we need to select a
- // suboptimal kernel for computation that has the expected memory size requirements
+ // MKLDNN introduced padded formats since 0.15 which require more
Review comment:
Good catch. I forgot that there is no _.clang-format_ file in v1.x repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-942187995
Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, unix-gpu, clang, edge, windows-gpu, sanity, website, centos-gpu, centos-cpu, windows-cpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-951773408
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-942309591
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-942309591
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-1023017284
Jenkins CI successfully triggered : [unix-gpu, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-943146028
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.1
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#issuecomment-943146083
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org