[GitHub] [thrift] Jens-G commented on a diff in pull request #2559: THRIFT-5551: java generator to add @Override where possible

[GitBox <gi...@apache.org>]

Jens-G commented on code in PR #2559:
URL: https://github.com/apache/thrift/pull/2559#discussion_r849846235


##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -3172,6 +3189,7 @@ void t_java_generator::generate_service_async_client(t_service* tservice) {
   indent(f_service_) << "    this.clientManager = clientManager;" << endl;
   indent(f_service_) << "    this.protocolFactory = protocolFactory;" << endl;
   indent(f_service_) << "  }" << endl;
+  indent(f_service_) << "  @Override" << endl;

Review Comment:
   That's a test, right? Seen and fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org