[GitHub] [beam] AnandInguva commented on a diff in pull request #21968: Replace distutils with supported modules.

[GitBox <gi...@apache.org>]

AnandInguva commented on code in PR #21968:
URL: https://github.com/apache/beam/pull/21968#discussion_r904230272


##########
.github/workflows/build_wheels.yml:
##########
@@ -240,7 +240,7 @@ jobs:
       working-directory: apache-beam-source
       env:
         CIBW_BUILD: ${{ matrix.os_python.python }}
-        CIBW_BEFORE_BUILD: pip install cython
+        CIBW_BEFORE_BUILD: pip install cython && pip install --upgrade setuptools

Review Comment:
   Looking at the code base, there was never a version pinned to the setuptools.  it was `pip install setuptools` most of the times[1](https://github.com/apache/beam/blob/6e25012b8d1cf1e690cda580cd00ae035b733324/sdks/python/container/run_generate_requirements.sh#L58). 
   
   The image used to build github wheels use a very old version of setuptools. I guess it would be on positive note if we update setuptools IIUC.
   
   @tvalentyn what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org