[GitHub] [flink] wanglijie95 commented on a diff in pull request #22367: [FLINK-27144][runtime] Provide timeout details when calling FutureUtils.orTimeout

["wanglijie95 (via GitHub)" <gi...@apache.org>]

wanglijie95 commented on code in PR #22367:
URL: https://github.com/apache/flink/pull/22367#discussion_r1165289123


##########
flink-core/src/test/java/org/apache/flink/util/concurrent/FutureUtilsTest.java:
##########
@@ -294,7 +294,7 @@ public void testOrTimeout() throws Exception {
         final CompletableFuture<String> future = new CompletableFuture<>();
         final long timeout = 10L;
 
-        FutureUtils.orTimeout(future, timeout, TimeUnit.MILLISECONDS);
+        FutureUtils.orTimeout(future, timeout, TimeUnit.MILLISECONDS, "testOrTimeout");
 
         try {
             future.get();

Review Comment:
   Added



##########
flink-tests/src/test/java/org/apache/flink/runtime/operators/coordination/OperatorEventSendingCheckpointITCase.java:
##########
@@ -259,7 +259,12 @@ public Long map(Long value) throws Exception {
 
     private static CompletableFuture<Acknowledge> askTimeoutFuture() {
         final CompletableFuture<Acknowledge> future = new CompletableFuture<>();
-        FutureUtils.orTimeout(future, 500, TimeUnit.MILLISECONDS);
+        long timeout = 500;

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org