You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/09/29 09:34:24 UTC

svn commit: r1867713 - in /ofbiz/ofbiz-plugins/branches/release18.12: ./ ecommerce/template/catalog/ConfigProductDetail.ftl

Author: jleroux
Date: Sun Sep 29 09:34:24 2019
New Revision: 1867713

URL: http://svn.apache.org/viewvc?rev=1867713&view=rev
Log:
"Applied fix from plugins for revision: 1867712" 
------------------------------------------------------------------------
r1867712 | jleroux | 2019-09-29 11:31:59 +0200 (dim. 29 sept. 2019) | 9 lignes

Improved: UI issue on ecommerce Product page
(OFBIZ-10884)

Navigate to demo-trunk ecom
Click on Product titled as Enchiladas, It redirects to the product page
On the Product page, Multiple horizontal lines are displayed 

Thanks: Garima jain for report, Sourabh Punyani for initial patch and Jayesh 
Agrawal for updated patch
------------------------------------------------------------------------

Modified:
    ofbiz/ofbiz-plugins/branches/release18.12/   (props changed)
    ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ConfigProductDetail.ftl

Propchange: ofbiz/ofbiz-plugins/branches/release18.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Sep 29 09:34:24 2019
@@ -10,4 +10,4 @@
 /ofbiz/branches/json-integration-refactoring/plugins:1634077-1635900
 /ofbiz/branches/multitenant20100310/plugins:921280-927264
 /ofbiz/branches/release13.07/plugins:1547657
-/ofbiz/ofbiz-plugins/trunk:1851002,1851009,1851068,1851135,1851139-1851140,1851185,1851316,1851885,1852988,1853904,1854684,1855082,1855084,1856212,1856802,1856917,1857120,1857173,1858141,1858244,1858265,1858285,1858289,1858312,1859012,1859735,1859893,1859906,1860648,1860801,1861824,1861904,1861986,1862466,1865347,1865398,1865828
+/ofbiz/ofbiz-plugins/trunk:1851002,1851009,1851068,1851135,1851139-1851140,1851185,1851316,1851885,1852988,1853904,1854684,1855082,1855084,1856212,1856802,1856917,1857120,1857173,1858141,1858244,1858265,1858285,1858289,1858312,1859012,1859735,1859893,1859906,1860648,1860801,1861824,1861904,1861986,1862466,1865347,1865398,1865828,1867712

Modified: ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ConfigProductDetail.ftl
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ConfigProductDetail.ftl?rev=1867713&r1=1867712&r2=1867713&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ConfigProductDetail.ftl (original)
+++ ofbiz/ofbiz-plugins/branches/release18.12/ecommerce/template/catalog/ConfigProductDetail.ftl Sun Sep 29 09:34:24 2019
@@ -476,6 +476,7 @@ ${virtualJavaScript!}
       </td>
     </tr>
   <#-- Long description of product -->
+  <#if productContentWrapper.get("LONG_DESCRIPTION", "html") != "">
     <tr>
       <td colspan="2">
         <div>${productContentWrapper.get("LONG_DESCRIPTION", "html")!}</div>
@@ -486,6 +487,7 @@ ${virtualJavaScript!}
         <hr class='sepbar'/>
       </td>
     </tr>
+  </#if>
   <#-- Any attributes/etc may go here -->
   <#-- Product Configurator -->
     <tr>
@@ -676,6 +678,7 @@ ${virtualJavaScript!}
       </td>
     </tr>
   <#-- Product Reviews -->
+    <#if productReviews?has_content>
     <tr>
       <td colspan="2">
         <div>${uiLabelMap.OrderCustomerReviews}:</div>
@@ -691,7 +694,6 @@ ${virtualJavaScript!}
         <hr class='sepbar'/>
       </td>
     </tr>
-  <#if productReviews?has_content>
     <#list productReviews as productReview>
       <#assign postedUserLogin = productReview.getRelatedOne("UserLogin", false)>
       <#assign postedPerson = postedUserLogin.getRelatedOne("Person", false)!>