You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2018/07/21 19:51:51 UTC

[3/4] hive git commit: HIVE-20046 : remove NUM_FILES check (Sergey Shelukhin)

HIVE-20046 : remove NUM_FILES check (Sergey Shelukhin)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/ddef8952
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/ddef8952
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/ddef8952

Branch: refs/heads/master-txnstats
Commit: ddef89525eaef9f5eeea4029475a24b891a41df7
Parents: 31ee870
Author: sergey <se...@apache.org>
Authored: Sat Jul 21 12:32:43 2018 -0700
Committer: sergey <se...@apache.org>
Committed: Sat Jul 21 12:32:43 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hive/metastore/ObjectStore.java    | 7 -------
 1 file changed, 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/ddef8952/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
----------------------------------------------------------------------
diff --git a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
index b319e68..9c46b68 100644
--- a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
+++ b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
@@ -12473,13 +12473,6 @@ public class ObjectStore implements RawStore, Configurable {
       return false;
     }
 
-    // TODO## NUM_FILES could also be set to 0 by invalid update. We need to have a negative test. Or remove this and fix stuff.
-    // If the NUM_FILES of the table/partition is 0, return 'true' from this method.
-    // Since newly initialized empty table has 0 for the parameter.
-    if (Long.parseLong(statsParams.get(StatsSetupConst.NUM_FILES)) == 0) {
-      return true;
-    }
-
     if (queryValidWriteIdList != null) { // Can be null when stats are being reset to invalid.
       ValidWriteIdList list4TheQuery = new ValidReaderWriteIdList(queryValidWriteIdList);
       // Just check if the write ID is valid. If it's valid (i.e. we are allowed to see it),