You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "meonkeys (via GitHub)" <gi...@apache.org> on 2025/03/14 18:15:15 UTC
[PR] FINERACT-2216: add github project metadata [fineract]
meonkeys opened a new pull request, #4464:
URL: https://github.com/apache/fineract/pull/4464
1. Link to project homepage at https://fineract.apache.org
2. Add some tags/labels/topics
See also:
* https://github.com/apache/infrastructure-asfyaml#repo_meta
* https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/classifying-your-repository-with-topics
## Description
See https://issues.apache.org/jira/browse/FINERACT-2216
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4464:
URL: https://github.com/apache/fineract/pull/4464#issuecomment-2729539107
This is only so we're able to set a more useful project description, homepage link, and labels.
See https://github.com/apache/infrastructure-asfyaml/blob/main/asfyaml/feature/github/__init__.py#L57
GitHub derives the project license from the `LICENSE_*` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4464:
URL: https://github.com/apache/fineract/pull/4464#issuecomment-2731265721
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4464:
URL: https://github.com/apache/fineract/pull/4464#issuecomment-2739131442
Oh cool and it already worked. Looks great. Thanks guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4464:
URL: https://github.com/apache/fineract/pull/4464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4464:
URL: https://github.com/apache/fineract/pull/4464#issuecomment-2729587426
Oh I see! Ok, will do. I'll also sign my commits... I'm trying to get in that habit too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2216: add github project metadata [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4464:
URL: https://github.com/apache/fineract/pull/4464#issuecomment-2729570002
@meonkeys Okay, but you either need to add the regular Apache license to this file or add this file to the exclusion list:
```build.gradle:242```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org