You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2010/11/17 00:11:13 UTC

[jira] Created: (TAP5-1350) TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs
-------------------------------------------------------------------------------------------------

                 Key: TAP5-1350
                 URL: https://issues.apache.org/jira/browse/TAP5-1350
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.2.5
            Reporter: Howard M. Lewis Ship


Currently, only this method is provided:

    protected ModuleDef[] provideExtraModuleDefs(ServletContext context)

The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).

An additional method:

  protected Class provideExtraModuleClasses(ServletContext context);

would fit the bill.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (TAP5-1350) TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113788#comment-13113788 ] 

Hudson commented on TAP5-1350:
------------------------------

Integrated in tapestry-trunk-freestyle #538 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/538/])
    TAP5-1350: TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174977
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TapestryFilter.java


> TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1350
>                 URL: https://issues.apache.org/jira/browse/TAP5-1350
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> Currently, only this method is provided:
>     protected ModuleDef[] provideExtraModuleDefs(ServletContext context)
> The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).
> An additional method:
>   protected Class provideExtraModuleClasses(ServletContext context);
> would fit the bill.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1350) TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113788#comment-13113788 ] 

Hudson commented on TAP5-1350:
------------------------------

Integrated in tapestry-trunk-freestyle #538 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/538/])
    TAP5-1350: TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174977
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TapestryFilter.java


> TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1350
>                 URL: https://issues.apache.org/jira/browse/TAP5-1350
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> Currently, only this method is provided:
>     protected ModuleDef[] provideExtraModuleDefs(ServletContext context)
> The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).
> An additional method:
>   protected Class provideExtraModuleClasses(ServletContext context);
> would fit the bill.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1350) TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1350.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship

> TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1350
>                 URL: https://issues.apache.org/jira/browse/TAP5-1350
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> Currently, only this method is provided:
>     protected ModuleDef[] provideExtraModuleDefs(ServletContext context)
> The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).
> An additional method:
>   protected Class provideExtraModuleClasses(ServletContext context);
> would fit the bill.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1350) TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1350.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship

> TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1350
>                 URL: https://issues.apache.org/jira/browse/TAP5-1350
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.2.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> Currently, only this method is provided:
>     protected ModuleDef[] provideExtraModuleDefs(ServletContext context)
> The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).
> An additional method:
>   protected Class provideExtraModuleClasses(ServletContext context);
> would fit the bill.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira