[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #546: testing/ostest: update mqueue testing code

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #546:
URL: https://github.com/apache/incubator-nuttx-apps/pull/546#discussion_r551002447



##########
File path: testing/ostest/ostest_main.c
##########
@@ -300,6 +300,7 @@ static int user_main(int argc, char *argv[])
   for (; ; )
 #endif
     {
+#if 0

Review comment:
       why comment out the test code?

##########
File path: testing/ostest/timedmqueue.c
##########
@@ -153,21 +154,23 @@ static void *sender_thread(void *arg)
       status = mq_timedsend(g_send_mqfd, msg_buffer, TEST_MSGLEN, 42, &ts);
       if (status < 0)
         {
-          if (i == TEST_SEND_NMSGS-1 && errno == ETIMEDOUT)
+          if (i == TEST_SEND_NMSGS - 1 && errno == ETIMEDOUT)
             {
-              printf("sender_thread: mq_timedsend %d timed out as expected\n", i);
+              printf("sender_thread: mq_timedsend %d"

Review comment:
       add space at the end

##########
File path: testing/ostest/timedmqueue.c
##########
@@ -369,8 +378,8 @@ void timedmqueue_test(void)
   status = pthread_attr_setstacksize(&attr, STACKSIZE);
   if (status != 0)
     {
-      printf("timedmqueue_test: pthread_attr_setstacksize failed, status=%d\n",
-             status);
+      printf("timedmqueue_test: pthread_attr_setstacksize failed,"

Review comment:
       add space at the end

##########
File path: testing/ostest/timedmqueue.c
##########
@@ -335,8 +344,8 @@ void timedmqueue_test(void)
   status = pthread_attr_setstacksize(&attr, STACKSIZE);
   if (status != 0)
     {
-      printf("timedmqueue_test: pthread_attr_setstacksize failed, status=%d\n",
-             status);
+      printf("timedmqueue_test: pthread_attr_setstacksize failed,"

Review comment:
       add space at the end




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org